[Vega] Improve error message in case of invalid $schema URL #114459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
flash1293
approved these changes
Oct 12, 2021
| schemaVersion: schema.version, | ||
| libraryVersion: libVersion, | ||
| }, | ||
| 'The URL for the JSON "$schema" is incorrect. Correct the URL, then click Update.', |
There was a problem hiding this comment.
nit: I would call it spec "$schema", as it's not necessarily JSON.
There was a problem hiding this comment.
I thought the $schema value cannot be anything else than a URL ending with json (source: https://github.com/vega/schema/blob/55615e9ec4d1aeae002799b90dff60aad9f31b19/parser.ts#L5 )
There was a problem hiding this comment.
Oh, I didn’t make this connection. Looks good to me then 👍
dej611
added a commit
to dej611/kibana
that referenced
this pull request
Oct 13, 2021
…114459) * 🐛 Catch the schema parser and provide a better error message * 🌐 Add i18n
dej611
added a commit
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #113899
This PR wraps the schema parser and provides a better error for the invalid case.
Checklist
Delete any items that are not applicable to this PR.