Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] lower roles.enabled deprecation to warning-level #114204

Merged
merged 16 commits into from
Oct 14, 2021
Merged

[Reporting] lower roles.enabled deprecation to warning-level #114204

merged 16 commits into from
Oct 14, 2021

Conversation

tsullivan
Copy link
Member

Summary

Resolves #113346

Screenshots

Before:
critical

After:
image
image

@tsullivan tsullivan mentioned this pull request Oct 6, 2021
Closed
@tsullivan tsullivan added Team:AppServicesUx v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 6, 2021
@tsullivan tsullivan requested review from a team and cjcenizal October 6, 2021 22:21
@cjcenizal
Copy link
Contributor

This looks great @tsullivan! I have two comments:

  • I suggest requesting a copywriting review from @debadair or @gchaps.
  • What happens to users who depend upon the current default value of xpack.reporting.roles.enabled? Will anything about their usage of Kibana or the behavior of Kibana be affected?

@tsullivan tsullivan changed the title Reporting/upgrade assistant transition 1 [Reporting] lower roles.enabled deprecation to warning-level Oct 7, 2021
@tsullivan tsullivan requested a review from gchaps October 7, 2021 01:01
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

debadair
debadair reviewed Oct 7, 2021
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gail & I reviewed. This might need some more iterations. :-)

debadair
debadair reviewed Oct 12, 2021
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment & updated the suggested text.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit a509752 into elastic:7.x Oct 14, 2021
@tsullivan tsullivan deleted the reporting/upgrade-assistant-transition-1 branch October 14, 2021 03:39
This was referenced Oct 14, 2021
Merged
Closed
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadair debadair debadair left review comments

@cjcenizal cjcenizal Awaiting requested review from cjcenizal

@gchaps gchaps Awaiting requested review from gchaps

Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tsullivan @cjcenizal @kibanamachine @debadair @sophiec20