Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] Node Advanced View #113628

Merged
merged 4 commits into from
Oct 4, 2021
Merged

[Stack Monitoring] Node Advanced View #113628

merged 4 commits into from
Oct 4, 2021

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Oct 1, 2021 •
edited
Loading

#113617

  • Node Advanced view
  • Navigation template for Node Overview/Advanced

Test

  • Navigate to Elasticsearch -> Nodes -> Click on an individual node from the list. There should be an Overview/Advanced tab
    Screen Shot 2021-10-01 at 10 20 51 AM
  • Clicking between Overview and Advanced should load correct views
  • Advanced view should auto refresh when enabled and charts should change
  • Refreshing the page should highlight the correct tab
  • Advanced view should not have a setupmode

@neptunian neptunian added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 Epic: Stack Monitoring de-angularization labels Oct 1, 2021
@neptunian neptunian self-assigned this Oct 1, 2021
@neptunian neptunian requested a review from a team as a code owner October 1, 2021 14:24
@neptunian neptunian requested review from a team October 1, 2021 14:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@neptunian neptunian mentioned this pull request Oct 1, 2021
Merged
@matschaffer
Copy link
Contributor

matschaffer commented Oct 4, 2021 •
edited
Loading

Testing (via docker-test-cluster)

  • Navigate to Elasticsearch -> Nodes -> Click on an individual node from the list. There should be an Overview/Advanced tab
  • Clicking between Overview and Advanced should load correct views
  • Advanced view should auto refresh when enabled and charts should change
  • Refreshing the page should highlight the correct tab
  • Advanced view should not have a setupmode

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@neptunian neptunian force-pushed the 113617-node-advanced-view branch from 8fdf1e9 to 4edcc5d Compare October 4, 2021 17:21
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 624 625 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 992.7KB 996.2KB +3.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@neptunian neptunian merged commit 6f2757d into elastic:master Oct 4, 2021
@kibanamachine kibanamachine mentioned this pull request Oct 4, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2021
@neptunian @kibanamachine
[Stack Monitoring] Node Advanced View (elastic#113628)
adbf25a 
* add template navigation

* implement advanced node view

* fix I18N titles
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 4, 2021
@kibanamachine @neptunian
[Stack Monitoring] Node Advanced View (#113628) (#113839)
c689608 
* add template navigation

* implement advanced node view

* fix I18N titles

Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matschaffer matschaffer matschaffer approved these changes

Assignees

@neptunian neptunian

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neptunian @elasticmachine @matschaffer @kibanamachine