Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] Convert cluster listing view to React #113585

Merged
merged 3 commits into from
Oct 5, 2021
Merged

[Stack Monitoring] Convert cluster listing view to React #113585

merged 3 commits into from
Oct 5, 2021

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Sep 30, 2021 •
edited
Loading

Summary

This PR closes #111761 by converting the "Cluster Listing" Angular view to React.

image

@simianhacker simianhacker added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes Feature:Stack Monitoring v7.16.0 Epic: Stack Monitoring de-angularization labels Sep 30, 2021
@simianhacker simianhacker marked this pull request as ready for review October 4, 2021 16:55
@simianhacker simianhacker requested a review from a team as a code owner October 4, 2021 16:55
@simianhacker simianhacker requested review from a team October 4, 2021 16:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker simianhacker added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 4, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 624 627 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 992.7KB 999.2KB +6.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

matschaffer
matschaffer approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. At first I thought sorting might be broken, but it worked after a refresh so guessing it's a browser artifact from flipping around versions/prs.

@simianhacker simianhacker enabled auto-merge (squash) October 5, 2021 15:24
@simianhacker simianhacker merged commit 141a88b into elastic:master Oct 5, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2021
@simianhacker @kibanamachine
[Stack Monitoring] Convert cluster listing view to React (elastic#113585
7a74d1e 
)

* [Stack Monitoring] Covnert cluster listing view to React

* Fixing localStorage
@kibanamachine kibanamachine mentioned this pull request Oct 5, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 5, 2021
@kibanamachine @simianhacker
[Stack Monitoring] Convert cluster listing view to React (#113585) (#…
2997a69 
…113953)

* [Stack Monitoring] Covnert cluster listing view to React

* Fixing localStorage

Co-authored-by: Chris Cowan <chris@chriscowan.us>
@simianhacker simianhacker deleted the issue-111761-convert-cluster-listing-view branch April 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matschaffer matschaffer matschaffer approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring][Angular removal] Migrate cluster listing view
4 participants
@simianhacker @elasticmachine @kibanamachine @matschaffer