[Expressions] Remove the any type usages

[dokmic]

Summary

Removed most of the any type usages from the expressions plugin.

Checklist

• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[stratoula]

LGTM, code review only!

[ppisljar]

arrow functions are preferred by our style guide if i remember correctly.

[dokmic]

I think it is not. Otherwise, that should be fixed there. Starting from TS 2.6, it has stricter type checks for the functions. When we define those methods as properties, which is unsound already, we are not able to extend or implement that interface with a subtype.

The following example will throw a compilation error:

interface A {
  foo: (bar: unknown) => number;
}

const a: A = {
  foo: (bar: number) => {
    return bar;
  },
};

class B implements A {
  foo(bar: number) {
    return bar;
  }
}

But this one will not:

interface A {
  foo(bar: unknown): number;
}

const a: A = {
  foo: (bar: number) => {
    return bar;
  },
};

class B implements A {
  foo(bar: number) {
    return bar;
  }
}

At first, I have fixed that for the methods with the any. But then I have corrected them all for consistency.

[ppisljar]

should we update getType function to return correct type ?

[dokmic]

The string is a supertype of the DatatableColumnType . That's fine to cast it here.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: c6129ed
• Storybooks Preview

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
expressions	1626	1646	+20

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
expressions	65	27	-38

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
expressions	122.5KB	122.6KB	+96.0B

Unknown metric groups

API count

id	before	after	diff
expressions	2072	2095	+23

History

• 💔 Build #157157 failed a54736d
• 💔 Build #157005 failed e33b6748ff7f764c5a6705efa08b0cfc4689cfd5
• 💔 Build #156890 failed d17e1866ac8f678064c6905534f0684dade6914d
• 💔 Build #156915 failed 245aa0c688f8c624369d3ee1336c53391057baf8
• 💚 Build #156582 succeeded 8d3b7431544a23718097df43be8a5c5f2a274d3e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[ppisljar]

code LGTM

[crob611]

Presentation changes look good 👍