Cleanup of the kibanaLegacy unused functions and remove unecessary dependencies from Analytics plugins

[stratoula]

Summary

Part of #76905
By removing angular from our plugins, we also no need to depend on the kibanaLegacy plugin. This PR, removes the dependency from the Analytics teams plugins as it was not used anymore.

Also it removes the unused functions from the kibana_legacy plugin. A second PR will follow after angular is removed from the monitoring plugin which will delete all the remaining angular from the plugin.

Our ultimate goal is to remove the kibana_legacy plugin.

[stratoula]

I haven't removed the dependency from the discover plugin as this function src/plugins/kibana_legacy/public/utils/inject_header_style.ts is needed for the truncate:maxHeight UI setting to work correctly. As the kibanaLegacy plugin is not disableable maybe it is safe to remove the dependency from the discover plugin but I am not 100% sure. @elastic/kibana-data-discovery wdyt?

Update: We discussed it offline. We are going to remove the dependency when the above functionality will be moved in the discover plugin.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: a0c0fd5
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
kibanaLegacy	58	35	-23

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
discoverEnhanced	37	35	-2
kibanaLegacy	64	45	-19
total			-21

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
kibanaLegacy	3	1	-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
kibanaLegacy	122.7KB	118.2KB	-4.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
kibanaLegacy	45.7KB	22.5KB	-23.2KB

Unknown metric groups

API count

id	before	after	diff
discoverEnhanced	39	37	-2
kibanaLegacy	68	48	-20
total			-22

async chunk count

id	before	after	diff
kibanaLegacy	2	1	-1

History

• 💔 Build #156357 failed cd04a45
• 💚 Build #156345 succeeded 6e6e9d7
• 💚 Build #156313 succeeded 3b5106e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[mbondyra]

Lovely PR 👏🏼 I think CI and functional tests give enough confidence to not even test it in this case but I ran it locally and opened all the involved parties (dashboard etc). Works with no problems!

[ThomThomson]

This is amazing! Looked over the dashboard changes, and it's incredible that I didn't notice we weren't using Kibana_legacy anymore. Thank you for removing it, and nothing is better than seeing +2 -1660 on a PR.

L G T M

[kertal]

LGTM, reviewed data discovery owned code. didn't test, but the usage of 'kibanaLegacy' in 'discover_enhanced' was always redundant, thx for the cleanup

[kibanamachine]

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 113358