[Fleet] Add test coverage for package policy variable overrides #113270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/fleet (Team:Fleet) |
|
Jest warned me about some obsolete snapshots in the Fleet project as well, so I had it clean those up. If that causes issues in CI/CD I'll revert those deletions. |
|
@elasticmachine merge upstream |
|
@kpollich Looks like the CI needed these snapshots |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kpollich |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 28, 2021
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
kpollich
added a commit
to kpollich/kibana
that referenced
this pull request
Sep 28, 2021
# Conflicts: # x-pack/plugins/fleet/server/services/package_policy.test.ts
kibanamachine
added a commit
that referenced
this pull request
Sep 28, 2021
kpollich
added a commit
that referenced
this pull request
Sep 28, 2021
|
Hi @kpollich Can you please share more details with us on how to validate above PR. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #113248
Add some baseline test coverage for
overridePackageInputsmethod that ensures our variable override logic works correctly. I verified the test's usefulness by reverting @jen-huang's change in #113204 and ensuring that the test failed.