Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Set breadcrumbs on update case title #113266

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

semd
Copy link
Contributor

@semd semd commented Sep 28, 2021

Summary

Fixes #104053

The breadcrumb for the case name is updated when the case title is edited, on both Security Solution and Observability.

case_name_breadcrumb.mov

@semd semd added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 Team:Threat Hunting:Cases labels Sep 28, 2021
@semd semd requested review from a team as code owners September 28, 2021 14:01
@semd semd self-assigned this Sep 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-cases (Team:Threat Hunting:Cases)

@semd semd enabled auto-merge (squash) September 29, 2021 10:49
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / Should have the same query and open the timeline modal.Create a timeline from a template Should have the same query and open the timeline modal

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

CypressError: Timed out retrying after 60050ms: `cy.click()` failed because this element:

`<button class="euiButtonIcon euiButtonIcon--text euiButtonIcon--empty euiButtonIcon--xSmall" type="button" aria-label="All actions" data-test-subj="euiCollapsedItemActionsButton">...</button>`

is being covered by another element:

`<div class="euiFlexGroup euiFlexGroup--alignItemsCenter euiFlexGroup--directionRow euiFlexGroup--responsive" aria-label="You are in group 1">...</div>`

Fix this problem, or use {force: true} to disable error checking.

https://on.cypress.io/element-cannot-be-interacted-with
    at $Cy.ensureDescendents (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:160669:87)
    at ensureDescendents (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:147543:8)
    at ensureDescendentsAndScroll (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:147550:14)
    at ensureElIsNotCovered (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:147684:5)
    at runAllChecks (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:147871:52)
    at retryActionability (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:147894:16)
    at tryCatcher (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:13212:23)
    at Function.Promise.attempt.Promise.try (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:10486:29)
    at tryFn (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:165329:61)
    at whenStable (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:165368:14)
    at http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:164855:18
    at tryCatcher (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:13212:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:11147:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:11204:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:11249:10)
    at Promise._settlePromises (http://elastic:changeme@localhost:61161/__cypress/runner/cypress_runner.js:11329:18)
From Your Spec Code:
    at Object.expandEventAction (http://localhost:61161/__cypress/tests?p=cypress/integration/timelines/creation.spec.ts:17239:61)
    at Context.eval (http://localhost:61161/__cypress/tests?p=cypress/integration/timelines/creation.spec.ts:15613:24)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 310.9KB 311.0KB +83.0B
observability 337.0KB 337.1KB +13.0B
securitySolution 4.3MB 4.3MB +23.0B
total +119.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd semd merged commit fd9dd2c into elastic:master Sep 29, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
* set title on breadcrumbs on update case title

* test case added
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
* set title on breadcrumbs on update case title

* test case added
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 29, 2021
* set title on breadcrumbs on update case title

* test case added

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
kibanamachine added a commit that referenced this pull request Sep 29, 2021
* set title on breadcrumbs on update case title

* test case added

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cases] Breadcrumb title is not updated when renaming case
5 participants