Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop explicit type annotations, fix typing #113230

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Drop explicit type annotations, fix typing #113230

merged 1 commit into from
Sep 29, 2021

Conversation

MiriamAparicio
Copy link
Contributor

What was done

  • Drop explicit type annotations left in previous PR
  • Fix typing

@MiriamAparicio MiriamAparicio requested a review from a team as a code owner September 28, 2021 08:39
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@MiriamAparicio MiriamAparicio added v7.16.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Sep 28, 2021
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv
sorenlouv reviewed Sep 28, 2021
View reviewed changes
x-pack/plugins/apm/server/lib/correlations/get_filters.ts
@@ -18,7 +17,6 @@ import {
import { ProcessorEvent } from '../../../common/processor_event';

export interface CorrelationsOptions {
setup: Setup;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why setup was removed from here and added in other places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't used there, I thought that was more convenient to extend the type where it's needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, makes sense

sorenlouv
sorenlouv reviewed Sep 28, 2021
View reviewed changes
x-pack/plugins/apm/server/lib/correlations/latency/get_overall_latency_distribution.ts
export async function getOverallLatencyDistribution(
options: CorrelationsOptions
) {
export async function getOverallLatencyDistribution(options: Options) {
const { setup } = options;
Copy link
Member

@sorenlouv sorenlouv Sep 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like setup is only used for getting the apmEventClient:

    const { apmEventClient } = setup;

We should extract that out of setup so we can pass it around separately similar to start and end (although that can wait)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create an issue for the extra work that can be made there, there were some other things we talked about but were out of scope of this task.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new issue with the left-overs is very welcome, thanks!

@MiriamAparicio MiriamAparicio merged commit 93debf4 into elastic:master Sep 29, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
@MiriamAparicio @kibanamachine
Drop explicit type annotations, fix typing (elastic#113230)
1bffcd9
@kibanamachine kibanamachine mentioned this pull request Sep 29, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 29, 2021
@kibanamachine @MiriamAparicio
Drop explicit type annotations, fix typing (#113230) (#113360)
16dea51 
Co-authored-by: Miriam <31922082+MiriamAparicio@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MiriamAparicio @elasticmachine @kibanamachine @sorenlouv