Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] update chromedriver to 94 #113153

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

dmlemeshko
Copy link
Member

Summary

Follow-up to #112847

Updating driver to match current Chrome version

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dmlemeshko dmlemeshko added v6.8.20 v7.15.1 v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 27, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko requested a review from a team September 28, 2021 10:35
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko merged commit fe91978 into elastic:master Sep 28, 2021
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Sep 28, 2021
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Sep 28, 2021
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Sep 28, 2021
dmlemeshko added a commit that referenced this pull request Sep 28, 2021
@dmlemeshko dmlemeshko deleted the bump-chromedriver-to-94 branch January 31, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v6.8.20 v7.15.1 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants