Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY] Add Privilege deprecations services in security plugin #113151

Merged
merged 18 commits into from
Oct 5, 2021
Merged

[SECURITY] Add Privilege deprecations services in security plugin #113151

merged 18 commits into from
Oct 5, 2021

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Sep 27, 2021

Summary

Adding a new services to allow kibana plugin to deprecated roles if needed it.

Checklist

@XavierM XavierM added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Sep 27, 2021
@XavierM XavierM requested a review from a team as a code owner September 27, 2021 17:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

This was referenced Sep 27, 2021
Merged
Closed
jportner
jportner reviewed Sep 30, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking great, just a few nits. Thanks for putting this together!

jportner
jportner reviewed Sep 30, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more nits that I noticed right after I submitted my review! 😅

@XavierM XavierM requested a review from jportner October 1, 2021 17:54
@XavierM XavierM added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 1, 2021
jportner
jportner reviewed Oct 4, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit, otherwise LGTM!

@XavierM XavierM enabled auto-merge (squash) October 4, 2021 23:35
@XavierM
Copy link
Contributor Author

XavierM commented Oct 5, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
security 456 457 +1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
security 6 7 +1
Unknown metric groups

API count

id before after diff
security 112 113 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM disabled auto-merge October 5, 2021 15:14
@XavierM XavierM enabled auto-merge (squash) October 5, 2021 15:14
@XavierM XavierM self-assigned this Oct 5, 2021
@XavierM XavierM requested a review from jportner October 5, 2021 15:22
jportner
jportner approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@XavierM XavierM merged commit 77675d9 into elastic:master Oct 5, 2021
@kibanamachine kibanamachine mentioned this pull request Oct 5, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2021
@XavierM @legrego
@jportner @kibanamachine
[SECURITY] Add Privilege deprecations services in security plugin (el…
14945b4 
…astic#113151)

* non-working POC for privilege deprecations

* wip to be bale to deprecated sub feature case in security solutions

* finalyze deprecations of cases sub feature in security solutions

* only adding the deprecation servces in security

* add test + translation

* Update x-pack/plugins/security/server/deprecations/privilege_deprecations.ts

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* joe reviews

* renaming + double check

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 5, 2021
@kibanamachine @XavierM
@legrego @jportner
[SECURITY] Add Privilege deprecations services in security plugin (#1…
748677e 
…13151) (#113955)

* non-working POC for privilege deprecations

* wip to be bale to deprecated sub feature case in security solutions

* finalyze deprecations of cases sub feature in security solutions

* only adding the deprecation servces in security

* add test + translation

* Update x-pack/plugins/security/server/deprecations/privilege_deprecations.ts

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* joe reviews

* renaming + double check

Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
This was referenced Oct 14, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

Assignees

@XavierM XavierM

Labels
auto-backport Deprecated - use backport:version if exact versions are needed enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XavierM @elasticmachine @kibanamachine @jportner @legrego