-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Expressions] Partial results example plugin #113001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcee671
to
869e3d1
Compare
ppisljar
reviewed
Sep 27, 2021
ppisljar
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
869e3d1
to
882b437
Compare
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:ExpressionLanguage
Interpreter expression language (aka canvas pipeline)
release_note:skip
Skip the PR/issue when compiling release notes
review
v7.16.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #108682.
This PR also changes the
mapColumn
function implementation to support partial results.At first, the idea was to emit table rows gradually upon expression resolution, but it affects the performance significantly. The implementation using
merge
will emit the number of values equals to the rows number. Using all possible optimizations, the duration was tripled on the demo data (about 3000 rows), which was unacceptably slow.In the result, the best solution was to use
combineLatest
and wait until the expression emits at least one value for every row. That doesn't affect the performance of the function and adds support of the partial results if the underlying expression emits multiple values.Checklist
For maintainers