Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timelion] Better error details on expression evaluation #112663

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Sep 21, 2021

Summary

Fixes (partially) #107399
This is a first part of the fix for the linked issue: now the server can send more details about the error due to expression evaluation and the client can show it.

Screenshot 2021-09-21 at 14 51 29

Next step should be probably to provide better error messages from the server side.

Checklist

Delete any items that are not applicable to this PR.

@dej611 dej611 added Feature:Timelion Timelion app and visualization release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 21, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTimelion 10.2KB 10.3KB +19.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 marked this pull request as ready for review September 21, 2021 15:28
@dej611 dej611 requested a review from a team as a code owner September 21, 2021 15:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is a great improvement from the previous state. For example when the interval is so small, now the error message makes more sense than the previous generic one. I agree that also the server errors could be improved but still I find it a very good enhancement :)
image

LGTM! Thanx Marco :)

@dej611 dej611 merged commit 914f2b7 into elastic:master Sep 22, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
Unexpected response from Github API (v4):
{
"message": "We had issues producing the response to your request. Sorry about that. Please try resubmitting your request and contact us if the problem persists."
}

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 112663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Timelion Timelion app and visualization release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants