-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Fix add to dashboard functional test flakiness #111887
Conversation
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only code review but the change makes sense to me
60 agents run enabling also the dnd lens suite: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1894/ (the branch is just a fork of this + the dnd tests enabled) I've setup initially a 100 agents run on the flaky runner but it went into timeout (with still no failures for the last 4 agents). cc @mbondyra |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Fixes #111628
This PR addresses some flaky factors in #111628 issue as it is not strictly required for the functional test.
Flaky runner tests (100 agents) for the
lens app
full suite: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1881/Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers