Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix add to dashboard functional test flakiness #111887

Merged
merged 6 commits into from
Sep 14, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Sep 10, 2021

Summary

Fixes #111628

This PR addresses some flaky factors in #111628 issue as it is not strictly required for the functional test.

Flaky runner tests (100 agents) for the lens app full suite: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1881/

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens labels Sep 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only code review but the change makes sense to me

@mbondyra
Copy link
Contributor

Hey @dej611 along with this test, the other one started breaking when you merged the same PR: #108352
Could you take a look and assess if the fix can help here too?

@mbondyra mbondyra changed the title [Lens] Fix add to dashboard functional test flakyness [Lens] Fix add to dashboard functional test flakiness Sep 13, 2021
@dej611 dej611 requested a review from a team as a code owner September 14, 2021 14:28
@dej611
Copy link
Contributor Author

dej611 commented Sep 14, 2021

60 agents run enabling also the dnd lens suite: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1894/ (the branch is just a fork of this + the dnd tests enabled)

I've setup initially a 100 agents run on the flaky runner but it went into timeout (with still no failures for the last 4 agents).

cc @mbondyra

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 added v7.16.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Sep 14, 2021
@dej611 dej611 merged commit 2262cac into elastic:master Sep 14, 2021
@dej611 dej611 deleted the fix/111628 branch September 14, 2021 16:53
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 14, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 15, 2021
)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
dej611 added a commit to kibanamachine/kibana that referenced this pull request Sep 16, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
5 participants