Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Changes link version to master in APM links #111685

Merged
merged 3 commits into from
Sep 9, 2021
Merged

[APM] Changes link version to master in APM links #111685

merged 3 commits into from
Sep 9, 2021

Conversation

szabosteve
Copy link
Contributor

Summary

This PR hard-codes the version of the APM links in the docs links service to master instead of using ${DOC_LINK_VERSION}. This is necessary because the APM books don't have a 7x version built, so the Kibana link check fails on 7x.

Related to: elastic/docs#2209

@szabosteve szabosteve added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Sep 9, 2021
@szabosteve szabosteve requested a review from a team as a code owner September 9, 2021 08:24
@szabosteve szabosteve added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@szabosteve szabosteve requested a review from lcawl September 9, 2021 08:26
@elastic elastic deleted a comment from kibanamachine Sep 9, 2021
@szabosteve
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 408.1KB 408.1KB -45.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@szabosteve szabosteve merged commit cac4957 into elastic:master Sep 9, 2021
@szabosteve szabosteve deleted the fix.apm.links branch September 9, 2021 13:10
@szabosteve szabosteve mentioned this pull request Sep 9, 2021
Merged
szabosteve added a commit to szabosteve/kibana that referenced this pull request Sep 9, 2021
@szabosteve @kibanamachine
[APM] Changes link version to master in APM links. (elastic#111685)
cd4ecd4 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
szabosteve added a commit that referenced this pull request Sep 9, 2021
@szabosteve @kibanamachine
[APM] Changes link version to master in APM links. (#111685) (#111724)
513897a 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@lcawl lcawl Awaiting requested review from lcawl

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szabosteve @elasticmachine @kibanamachine @sorenlouv @pgayvallet