[Security Solution][Endpoint] Do not validate TA creation form with soft errors when required name field is empty #111508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
dasansol92
reviewed
Sep 8, 2021
...lution/public/management/pages/trusted_apps/view/components/create_trusted_app_form.test.tsx
Show resolved
Hide resolved
...ty_solution/public/management/pages/trusted_apps/view/components/create_trusted_app_form.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @ashokaditya |
|
Checked it out - working as expected!
|
kevinlog
approved these changes
Sep 8, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 8, 2021
…oft errors when required name field is empty (elastic#111508) * validate to true only if name is not empty as well fixes elastic/issues/108509 * update test * review changes
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 8, 2021
…oft errors when required name field is empty (#111508) (#111533) * validate to true only if name is not empty as well fixes /issues/108509 * update test * review changes Co-authored-by: Ashokaditya <am.struktr@gmail.com>
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Sep 8, 2021
…oft errors when required name field is empty (elastic#111508) * validate to true only if name is not empty as well fixes elastic/issues/108509 * update test * review changes
Bug Conversion
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug when the Path field input values result in soft warnings and not errors. This ends up as validating the form even though the required Name field is empty.
Screenshot
Checklist
Delete any items that are not applicable to this PR.