Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] [Observability] Disable RAC feature flags again #111264

Closed
wants to merge 1 commit into from
Closed

[RAC] [Observability] Disable RAC feature flags again #111264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/observability/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ export const config = {
index: schema.string({ defaultValue: 'observability-annotations' }),
}),
unsafe: schema.object({
alertingExperience: schema.object({ enabled: schema.boolean({ defaultValue: true }) }),
cases: schema.object({ enabled: schema.boolean({ defaultValue: true }) }),
alertingExperience: schema.object({ enabled: schema.boolean({ defaultValue: false }) }),
cases: schema.object({ enabled: schema.boolean({ defaultValue: false }) }),
}),
}),
};
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/rule_registry/server/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const config = {
schema: schema.object({
enabled: schema.boolean({ defaultValue: true }),
write: schema.object({
enabled: schema.boolean({ defaultValue: true }),
enabled: schema.boolean({ defaultValue: false }),
}),
unsafe: schema.object({
legacyMultiTenancy: schema.object({
Expand Down
9 changes: 1 addition & 8 deletions x-pack/test/functional/apps/apm/feature_controls/apm_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const navLinks = await appsMenu.readLinks();
expect(navLinks.map((link) => link.text)).to.eql([
'Overview',
'Alerts',
'APM',
'User Experience',
'Stack Management',
Expand Down Expand Up @@ -117,13 +116,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

it('shows apm navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql([
'Overview',
'Alerts',
'APM',
'User Experience',
'Stack Management',
]);
expect(navLinks).to.eql(['Overview', 'APM', 'User Experience', 'Stack Management']);
});

it('can navigate to APM app', async () => {
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional/apps/infra/feature_controls/infrastructure_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

it('shows metrics navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Overview', 'Alerts', 'Metrics', 'Stack Management']);
expect(navLinks).to.eql(['Overview', 'Metrics', 'Stack Management']);
});

describe('infrastructure landing page without data', () => {
Expand Down Expand Up @@ -160,7 +160,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

it('shows metrics navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Overview', 'Alerts', 'Metrics', 'Stack Management']);
expect(navLinks).to.eql(['Overview', 'Metrics', 'Stack Management']);
});

describe('infrastructure landing page without data', () => {
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional/apps/infra/feature_controls/logs_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

it('shows logs navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Overview', 'Alerts', 'Logs', 'Stack Management']);
expect(navLinks).to.eql(['Overview', 'Logs', 'Stack Management']);
});

describe('logs landing page without data', () => {
Expand Down Expand Up @@ -122,7 +122,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

it('shows logs navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Overview', 'Alerts', 'Logs', 'Stack Management']);
expect(navLinks).to.eql(['Overview', 'Logs', 'Stack Management']);
});

describe('logs landing page without data', () => {
Expand Down
8 changes: 4 additions & 4 deletions x-pack/test/functional/apps/observability/feature_controls/observability_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});

it('shows observability/cases navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.contain('Cases');
const navLinks = (await appsMenu.readLinks()).map((link) => link.text).slice(0, 2);
expect(navLinks).to.eql(['Overview', 'Cases']);
});

it(`landing page shows "Create new case" button`, async () => {
Expand Down Expand Up @@ -133,8 +133,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});

it('shows observability/cases navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.contain('Cases');
const navLinks = (await appsMenu.readLinks()).map((link) => link.text).slice(0, 2);
expect(navLinks).to.eql(['Overview', 'Cases']);
});

it(`landing page shows disabled "Create new case" button`, async () => {
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/uptime/feature_controls/uptime_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const navLinks = await appsMenu.readLinks();
expect(navLinks.map((link) => link.text)).to.eql([
'Overview',
'Alerts',
'Uptime',
'Stack Management',
]);
Expand Down Expand Up @@ -122,7 +121,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

it('shows uptime navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Overview', 'Alerts', 'Uptime', 'Stack Management']);
expect(navLinks).to.eql(['Overview', 'Uptime', 'Stack Management']);
});

it('can navigate to Uptime app', async () => {
Expand Down