Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix Heatmap in dashboard with numeric color stops #111117

Merged
merged 12 commits into from
Sep 8, 2021
Merged

[Lens] Fix Heatmap in dashboard with numeric color stops #111117

merged 12 commits into from
Sep 8, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Sep 3, 2021 •
edited
Loading

Summary

Fixes #111104

This PR addresses an issue when using Heatmap with absolute numeric color stops, when used in Dashboard.

I've added a dedicated functional test for this issue to spot it in the future.

Checklist

Delete any items that are not applicable to this PR.

@dej611 dej611 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v7.15.1 labels Sep 3, 2021
@dej611 dej611 marked this pull request as ready for review September 3, 2021 14:26
@dej611 dej611 requested a review from a team as a code owner September 3, 2021 14:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@mbondyra
Copy link
Contributor

mbondyra commented Sep 6, 2021

@elasticmachine merge upstream

mbondyra
mbondyra approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the bug is fixed. Code LGTM 🆗 There is a small CI problem with types, but approving to not block you.

@dej611
Copy link
Contributor Author

dej611 commented Sep 7, 2021

@elasticmachine merge upstream

@dej611
Copy link
Contributor Author

dej611 commented Sep 8, 2021

@elasticmachine merge upstream

@dej611
Copy link
Contributor Author

dej611 commented Sep 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.6MB 1.6MB +361.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit b36ffc9 into elastic:master Sep 8, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2021
@dej611 @kibanamachine
[Lens] Fix Heatmap in dashboard with numeric color stops (elastic#111117
6a6678b 
)

* 🐛 Fix heatmap numeric stops problem + tests

* 🏷️ Fix type issue

* ✅ Add dashboard functional tests for this issue

* ✅ Simplify functional test

* ✅ fix functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 8, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2021
@dej611 @kibanamachine
[Lens] Fix Heatmap in dashboard with numeric color stops (elastic#111117
4ec9767 
)

* 🐛 Fix heatmap numeric stops problem + tests

* 🏷️ Fix type issue

* ✅ Add dashboard functional tests for this issue

* ✅ Simplify functional test

* ✅ fix functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x
✅ 7.15

The backport PRs will be merged automatically after passing CI.

This was referenced Sep 8, 2021
Open
Closed
@spalger
Copy link
Contributor

spalger commented Sep 8, 2021

@dej611 this PR caused a lot of flakiness in the lens tests, which is kind of surprising based on the changes but was also evident in the failures which were occurring on the PR before merge. Please make sure you look at the failures which CI reports and that they are irrelevant before trying to get your PR green with @elasticmachine merge upstream comments. Please address this flakiness before merging these backports or revert this PR.

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
@dej611 @kibanamachine @chrisronline
[Lens] Fix Heatmap in dashboard with numeric color stops (elastic#111117
d1591a4 
)

* 🐛 Fix heatmap numeric stops problem + tests

* 🏷️ Fix type issue

* ✅ Add dashboard functional tests for this issue

* ✅ Simplify functional test

* ✅ fix functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 10, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Sep 14, 2021
@kibanamachine @dej611
[Lens] Fix Heatmap in dashboard with numeric color stops (#111117) (#…
bb0e065 
…111585)

* 🐛 Fix heatmap numeric stops problem + tests

* 🏷️ Fix type issue

* ✅ Add dashboard functional tests for this issue

* ✅ Simplify functional test

* ✅ fix functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

dej611 added a commit that referenced this pull request Sep 16, 2021
@kibanamachine @dej611
[Lens] Fix Heatmap in dashboard with numeric color stops (#111117) (#…
afde9bb 
…111586)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.1 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Heatmap with numeric color stops fail to load in dashboard
5 participants
@dej611 @elasticmachine @mbondyra @kibanamachine @spalger