[Montiroing] Add monitoring toolbar with date picker #110612
Conversation
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
| @@ -11,7 +11,6 @@ import { MonitoringStartPluginDependencies } from '../types'; | |||
| interface GlobalStateProviderProps { | |||
| query: MonitoringStartPluginDependencies['data']['query']; | |||
| toasts: MonitoringStartPluginDependencies['core']['notifications']['toasts']; | |||
| children: React.ReactNode; | |||
There was a problem hiding this comment.
I knew that this had to be wrong 😅 thanks for fixing it!
| import React, { useContext, useCallback } from 'react'; | ||
| import { MonitoringTimeContainer } from '../../application/pages/use_monitoring_time'; | ||
|
|
||
| export const MonitoringToolbar = () => { |
There was a problem hiding this comment.
This component should probably be used in the page template
| to: 'now', | ||
| interval: DEFAULT_TIMERANGE.interval, | ||
| }; | ||
| const [refreshInterval, setRefreshInterval] = useState(5000); |
There was a problem hiding this comment.
This value should be 10000.
|
|
||
| return ( | ||
| <EuiFlexGroup gutterSize={'xl'} justifyContent={'spaceBetween'}> | ||
| <EuiFlexItem>Setup Button</EuiFlexItem> |
There was a problem hiding this comment.
For later, but looks like the NoData screen doesn't show the setup button. Guessing we'll need a flag to hide it.
There was a problem hiding this comment.
@matschaffer the setup button should not be rendered from the template. It's rendered from the setup lib.
In the page template, we only need the container that is used from that method, so the only thing we need to do is some cleanup here.
|
@elasticmachine update branch |
|
Test failure is on alerting_api_integration so updated branch to see if master contains a fix (or maybe flakey). |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Add date picker with context to the new react app. Still needs some styling, but code is ready to be used.