-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Reverse colors should not reverse palette picker previews #110455
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maps changes LGTM
code review
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dej611 thanks for preparing testing saved objects. I tested by migrating the provided samples and my own SO (screenshot) too, just to be sure. Tested on Chrome and migrations work as expected.
Code LGTM
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
…stic#110455) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
Fixes #110290
This PR is an attempt to address the #110290 problem, while changing a bit the palette panel behaviour:
when revering a color stops configuration, this PR makes an automatic transition of the palette from the current state to a custom palette.
This means that the current saved palette configuration with predefined palettes and reverse option should be migrated to the new configuration.
Because the palette picker is now showing predefined palettes always with a direction, selecting one of these palettes resets the
reverse
flag.reverse
flagTesting
Create a new datatable and with a predefined palette reverse the color stops
Custom Palette
I've prepared a dashboard with 4 datatables using conditional coloring with a predefined palette (2 reversed + 2 regular) before the fix/migration (rename the extension from
txt
tondjson
and import it)Checklist
Delete any items that are not applicable to this PR.
Risk Matrix