-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.x] [RAC] EuiDataGrid pagination (#109269) #110442
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update T-Grid to use DataGrid pagination * It also improves the Gtid loading state * DataGrid pagination makes sure that we display the grid with the proper height. * Add DataGrid height hack to t-grid HUGE HACK!!! DataGrtid height isn't properly calculated when the grid has horizontal scroll. elastic/eui#5030 In order to get around this bug we are calculating `DataGrid` height here and setting it as a prop. Please revert this commit and allow DataGrid to calculate its height when the bug is fixed. * Apply DataGrid laoding and pagination changes to observability * Fix cypress tests * Fix t-grid page render bug on Observability * some pagination fixes * hide table when analyzer active * isolate exported function Co-authored-by: semd <sergi.massaneda@elastic.co> # Conflicts: # x-pack/plugins/timelines/public/components/t_grid/body/index.tsx
@elasticmachine merge upstream |
⏳ Build in-progress, with failures
Failed CI Steps
Test FailuresKibana Pipeline / jest / Jest Tests.x-pack/plugins/timelines/public/components/t_grid/body.Body rendering it renders the body data gridStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/timelines/public/components/t_grid/body.Body rendering it renders the column headersStandard Out
Stack Trace
Kibana Pipeline / jest / Jest Tests.x-pack/plugins/timelines/public/components/t_grid/body.Body rendering it renders the scroll containerStandard Out
Stack Trace
and 1 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
auto-merge was automatically disabled
August 30, 2021 13:11
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: