Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Add permissions for context size test #109391

Merged
merged 6 commits into from
Sep 6, 2021
Merged

[Discover] Add permissions for context size test #109391

merged 6 commits into from
Sep 6, 2021

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Aug 20, 2021

Summary

Fixes #98421
Flaky test runner build

Checklist

@dimaanj dimaanj added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Aug 20, 2021
@dimaanj dimaanj requested review from kertal and majagrubic August 20, 2021 09:39
@dimaanj dimaanj self-assigned this Aug 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dimaanj
Copy link
Contributor Author

dimaanj commented Aug 23, 2021

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Aug 26, 2021

@elasticmachine merge upstream

@kertal kertal requested a review from liza-mae August 26, 2021 15:24
@kertal
Copy link
Member

kertal commented Aug 26, 2021 •
edited
Loading

dear @liza-mae, could you evaluate in cloud CI ? last time I tried the cloud flaky test runner it didn't work. many thx!

liza-mae
liza-mae previously requested changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kertal it appears to be failing on cloud:

https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/JOB=flakyRun1,TASK=saas_run_kibana_tests,node=ess-testing/273/console

kertal
kertal reviewed Aug 26, 2021
View reviewed changes
test/functional/apps/context/_size.ts Outdated
@@ -28,6 +29,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'context:step': `${TEST_STEP_SIZE}`,
});
await PageObjects.context.navigateTo(TEST_INDEX_PATTERN, TEST_ANCHOR_ID);
await security.testUser.setRoles(['kibana_admin', 'kibana_date_nanos']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know if this fixes the issue, but I think roles need to be set before navigating to context?

@liza-mae
Copy link
Contributor

@kertal the order of the command did not seem to make a difference in my testing, however since the default index is logstash adding the test_logstash_reader role fixed it for me.

@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@dimaanj dimaanj requested review from liza-mae and kertal September 1, 2021 08:38
@dimaanj
Copy link
Contributor Author

dimaanj commented Sep 1, 2021

@elasticmachine merge upstream

kertal
kertal approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, flaky test runner in the cloud says, it works: https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/JOB=flakyRun1,TASK=saas_run_kibana_tests,node=ess-testing/274/

@dimaanj
Copy link
Contributor Author

dimaanj commented Sep 6, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@kertal kertal dismissed liza-mae’s stale review September 6, 2021 12:33

I've been re-running the flaky one that failed and it works

@dimaanj dimaanj merged commit 0d00943 into elastic:master Sep 6, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 6, 2021
@dimaanj @kibanamachine
[Discover] Add permissions for context size test (elastic#109391)
dc0cb4e 
* [Discover] add permissions for flaky context test

* [Discover] apply test_logstash_reader role

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 6, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 6, 2021
@dimaanj @kibanamachine
[Discover] Add permissions for context size test (elastic#109391)
25021fa 
* [Discover] add permissions for flaky context test

* [Discover] apply test_logstash_reader role

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 6, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 6, 2021
@kibanamachine @dimaanj
[Discover] Add permissions for context size test (#109391) (#111280)
c3eafbd 
* [Discover] add permissions for flaky context test

* [Discover] apply test_logstash_reader role

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Sep 6, 2021
@kibanamachine @dimaanj
[Discover] Add permissions for context size test (#109391) (#111281)
5ff03f3 
* [Discover] add permissions for flaky context test

* [Discover] apply test_logstash_reader role

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@majagrubic majagrubic Awaiting requested review from majagrubic

@liza-mae liza-mae Awaiting requested review from liza-mae

Assignees

@dimaanj dimaanj

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@dimaanj @elasticmachine @kertal @liza-mae @kibanamachine @timroes