[5.x] [console] support HEAD requests #10932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #10611 **Commit 1:** [console] support HEAD requests Hapi handles HEAD requests automatically (by ignoring the body of a GET response) which prevents the console proxy from handling them correctly. To fix this the console proxy now only accepts requests with the POST method and requires the path and method in the query string. * Original sha: d0aec25 * Authored by spalger <spalger@users.noreply.github.com> on 2017-02-28T02:03:23Z **Commit 2:** [console] proxy 'Warning' header from es * Original sha: 5e932e4 * Authored by spalger <spalger@users.noreply.github.com> on 2017-03-24T05:01:38Z **Commit 3:** Merge branch 'master' of github.com:elastic/kibana into fix/console-head-requests * Original sha: 3145506 * Authored by spalger <spalger@users.noreply.github.com> on 2017-03-28T23:04:50Z **Commit 4:** [console] fix lint errors * Original sha: c4f4bd8 * Authored by spalger <spalger@users.noreply.github.com> on 2017-03-28T23:08:42Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[console] support HEAD requests
Backports PR #10611
Commit 1:
[console] support HEAD requests
Hapi handles HEAD requests automatically (by ignoring the body of a GET response) which prevents the console proxy from handling them correctly. To fix this the console proxy now only accepts requests with the POST method and requires the path and method in the query string.
Commit 2:
[console] proxy 'Warning' header from es
Commit 3:
Merge branch 'master' of github.com:elastic/kibana into fix/console-head-requests
Commit 4:
[console] fix lint errors