Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] [Observability] Temporarily enable RAC feature flags #109113

Merged
merged 7 commits into from
Aug 23, 2021
Merged

[RAC] [Observability] Temporarily enable RAC feature flags #109113

merged 7 commits into from
Aug 23, 2021

Conversation

weltenwort
Copy link
Member

📝 Summary

This enables the feature flags for two weeks to ease testing in environments where the configuration file can't easily be modified. After two weeks a decision is made about keeping it on or reverting to the disabled-by-default state.

This means the following will happen:

  • the Observability cases page is visible by default
  • the Observability alerts page is visible by default
  • the Observability alerting rules write alert documents on execution which show up on the alerts page

related to #105237

FYI @elastic/uptime @elastic/apm-ui @elastic/logs-metrics-ui @mchopda @cyrille-leclerc

@weltenwort
Temporarily enable Observability RAC feature flags
6c1c0c0 
This enables the feature flags for two weeks until a decision is made
about keeping it on or reverting to the disabled-by-default state.
@weltenwort weltenwort added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Theme: rac label obsolete Feature:RAC label obsolete v7.15.0 v7.16.0 Feature:Observability RAC labels Aug 18, 2021
@weltenwort weltenwort self-assigned this Aug 18, 2021
@mistic mistic removed the v7.15.0 label Aug 18, 2021
@weltenwort weltenwort mentioned this pull request Aug 18, 2021
Closed
52 tasks
@weltenwort weltenwort marked this pull request as ready for review August 19, 2021 09:44
@weltenwort weltenwort requested review from a team as code owners August 19, 2021 09:44
@weltenwort weltenwort requested a review from a team August 19, 2021 09:44
@mgiota mgiota self-requested a review August 19, 2021 11:09
mgiota
mgiota approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgiota
Copy link
Contributor

mgiota commented Aug 19, 2021 •
edited
Loading

@weltenwort Probably unrelated but I got [error][apm][plugins] Could not get dynamic index pattern because indices "traces-apm*,logs-apm*,metrics-apm*,apm-*" don't exist when running yarn start on this branch.

Also Add to case and Add to existing case stopped working (clicking on the options doesn't do anything). Probably not a problem with this branch, but I will double check with master and see if this feature is broken there as well.

@weltenwort
Copy link
Member Author

@weltenwort Probably unrelated but I got [error][apm][plugins] Could not get dynamic index pattern because indices "traces-apm*,logs-apm*,metrics-apm*,apm-*" don't exist when running yarn start on this branch.

Also Add to case and Add to existing case stopped working (clicking on the options doesn't do anything). Probably not a problem with this branch, but I will double check with master and see if this feature is broken there as well.

Those are important, thank you for paying attention. We should definitely verify this on master.

@mgiota
Copy link
Contributor

mgiota commented Aug 19, 2021

Those are important, thank you for paying attention. We should definitely verify this on master.

I just checked on master and I get an empty table. No alerts whereas I should be getting one from inventory metric threshold for sure. I will post on a channel to see if others have issues

smith
smith approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes look ok.

@weltenwort
Copy link
Member Author

@mgiota we've identified a probable cause for what you're seeing. I created #109317 to track it and it's being worked on by @XavierM. Thanks for pointing it out.

justinkambic
justinkambic approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM

@XavierM
Copy link
Contributor

XavierM commented Aug 20, 2021

@elasticmachine merge upstream

@mgiota
Copy link
Contributor

mgiota commented Aug 22, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

@mgiota mgiota merged commit 627b2fd into elastic:master Aug 23, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@weltenwort @kibanamachine
[RAC] [Observability] Temporarily enable RAC feature flags (elastic#1…
5fd6bc3 
…09113)

* Temporarily enable Observability RAC feature flags

This enables the feature flags for two weeks until a decision is made
about keeping it on or reverting to the disabled-by-default state.

* Adapt uptime functional test

* Adapt additional functional tests

* Adapt cases functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@weltenwort @kibanamachine
[RAC] [Observability] Temporarily enable RAC feature flags (elastic#1…
be77c2d 
…09113)

* Temporarily enable Observability RAC feature flags

This enables the feature flags for two weeks until a decision is made
about keeping it on or reverting to the disabled-by-default state.

* Adapt uptime functional test

* Adapt additional functional tests

* Adapt cases functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 24, 2021
@kibanamachine @weltenwort
[RAC] [Observability] Temporarily enable RAC feature flags (#109113) (#…
b9590c3 
…109752)

* Temporarily enable Observability RAC feature flags

This enables the feature flags for two weeks until a decision is made
about keeping it on or reverting to the disabled-by-default state.

* Adapt uptime functional test

* Adapt additional functional tests

* Adapt cases functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Aug 24, 2021
@kibanamachine @weltenwort
[RAC] [Observability] Temporarily enable RAC feature flags (#109113) (#…
7dae9e6 
…109753)

* Temporarily enable Observability RAC feature flags

This enables the feature flags for two weeks until a decision is made
about keeping it on or reverting to the disabled-by-default state.

* Adapt uptime functional test

* Adapt additional functional tests

* Adapt cases functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
weltenwort added a commit that referenced this pull request Sep 6, 2021
@weltenwort
Revert "[RAC] [Observability] Temporarily enable RAC feature flags (#…
0731064 
…109113)"

This reverts commit 627b2fd.
@weltenwort weltenwort mentioned this pull request Sep 6, 2021
Closed
weltenwort added a commit to weltenwort/kibana that referenced this pull request Sep 6, 2021
@weltenwort
Revert "[RAC] [Observability] Temporarily enable RAC feature flags (e…
dbc035a 
…lastic#109113)"

This reverts commit 627b2fd.
@weltenwort weltenwort mentioned this pull request Sep 6, 2021
Merged
@shahzad31 shahzad31 mentioned this pull request Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgiota mgiota mgiota approved these changes

@smith smith smith approved these changes

@justinkambic justinkambic justinkambic approved these changes

Assignees

@weltenwort weltenwort

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Observability RAC Feature:RAC label obsolete release_note:skip Skip the PR/issue when compiling release notes Theme: rac label obsolete v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@weltenwort @mgiota @XavierM @kibanamachine @smith @justinkambic @mistic