issue-link js-issue-link" data-error-text="Failed to load title" data-id="210249520" data-permission-text="Title is private" data-url="https://github.com/elastic/kibana/issues/10585" data-hovercard-type="pull_request" data-hovercard-url="/elastic/kibana/pull/10585/hovercard" href="https://github.com/elastic/kibana/pull/10585">#10585 **Commit 1:** Start at view/edit mode 4 * Original sha: a89ce34 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-25T17:24:02Z **Commit 2:** Revert back to save panel - Get rid of `clone` - Get rid of rename * Original sha: cfb3372 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-25T17:35:05Z **Commit 3:** Move order of top nav component around so no chance of hitting Edit -> Cancel * Original sha: 000e857 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-25T17:43:07Z **Commit 4:** Update "lose changes" confirmation dialog - Change the string and button text - Set default focus on the cancel button. * Original sha: 542e7bf * Authored by Stacey Gammon <gammon@elastic.co> on 2017-02-28T16:03:39Z **Commit 5:** Remove DashboardViewMode It was previously used when viewMode wasn’t stored in appState, in order to keep an unsaved dashboard, that was just saved, in Edit mode. This is unnecessary in the latest iteration. * Original sha: 39ba9e3 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-01T21:51:09Z **Commit 6:** Pull time filter out of dashboard_state * Original sha: 7875547 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-02T16:01:16Z **Commit 7:** Fix edit controls bug, add more tests, make other tests more stable. * Original sha: 774267c * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-03T14:26:33Z **Commit 8:** Remove unnecessary logic, unapplied query bug fix, code clean up * Original sha: 9cf402a * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-03T18:19:15Z **Commit 9:** Fix bug on filter reloading, add tests & clean up * Original sha: 97c3054 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-03T20:30:11Z **Commit 10:** Fix issue with move and remove icons showing up in expanded panel mode and add tests to catch it. * Original sha: b8195c4 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-17T17:30:06Z **Commit 11:** Fix issue with lose changes not resetting panel state and add tests. * Original sha: f92d8f6 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-17T20:15:12Z **Commit 12:** General Clean Up - Merge function only used in one spot inline. Add comments * Original sha: badf336 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-17T20:50:55Z **Commit 13:** address code review comments * Original sha: 0c61fc7 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-21T14:11:41Z **Commit 14:** Stop using static + class to namespace functions Instead, export each function individually. * Original sha: b0745aa * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-22T13:18:27Z **Commit 15:** Show dashed border on maximized panels in edit mode. * Original sha: ec5393b * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-22T14:09:01Z **Commit 16:** Be more methodical about ensuring the modal dialog hides before continuing. * Original sha: 07a031f * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-22T14:26:56Z **Commit 17:** abide by new no unused vars rule * Original sha: 5e76980 * Authored by Stacey Gammon <gammon@elastic.co> on 2017-03-22T16:32:30Z

Commits

Commits on Mar 23, 2017

View edit 5