[RAC][Observability] Add status update actions in row menu #108698

semd · 2021-08-16T13:39:33Z

Summary

Toast management encapsulated inside the useStatusBulkActionItems public hook.
IndexName to update alert statuses taken from ecs data prop.
Pass new <Action> component props in order to show the loader.
Menu item sized unified.
Alert status update items added to the o11y row actions popover menu:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
This was checked for cross-browser compatibility

…s and adds logic for switching between signal.status and workflow status when updating alerts in .siem-signals

… to use WORKFLOW_STATUS instead of ALERT_STATUS

…dtion to KQL string

adds replace ALERT_STATUS with ALERT_WORKFLOW_STATUS and updates tests and adds logic for switching between signal.status and workflow status when updating alerts in .siem-signals

…s-rbac-update

…hz properties

…us' and not { signals: {status }} in alerts client

optionally use fields api in requests if _source does not contain authz properties

…emd/kibana into tgrid-bulk-actions-rbac-update

…g ids param in alerts bulk update. Adds integration tests for detection engine testing update alerts with new alerts as data client routes

…s-rbac-update

…test fix a bug where we were not waiting for updates to complete when usin…

…s-rbac-update

elasticmachine · 2021-08-16T19:34:33Z

Pinging @elastic/security-solution (Team: SecuritySolution)

x-pack/plugins/timelines/public/components/t_grid/body/index.tsx

semd · 2021-08-16T19:39:54Z

x-pack/plugins/timelines/public/hooks/use_status_bulk_action_items.tsx

@@ -48,6 +28,57 @@ export const useStatusBulkActionItems = ({
  onUpdateFailure,
 }: StatusBulkActionsProps) => {
  const { updateAlertStatus } = useUpdateAlertsStatus();
+  const { addSuccess, addError, addWarning } = useAppToasts();


Toast management encapsulated in the public component to prevent duplication. Still calls optional onUpdateSuccess and onUpdateFailure when needed

semd · 2021-08-16T19:40:25Z

x-pack/plugins/timelines/public/hooks/use_status_bulk_action_items.tsx

@@ -94,6 +125,7 @@ export const useStatusBulkActionItems = ({
          key="open"
          data-test-subj="open-alert-status"
          onClick={() => onClickUpdate(FILTER_OPEN)}
+          size="s"


Unification of item sizes

dplumlee

this all looks good from the security solution side of things and works for me, i should be able to build off this with the acknowledged migrations pretty easily 🚀

x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx

michaelolo24

LGTM!

kibanamachine · 2021-08-17T20:03:32Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`observability`	244	245	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	483.6KB	485.3KB	+1.7KB
`securitySolution`	6.5MB	6.5MB	-448.0B
`timelines`	421.2KB	409.2KB	-12.0KB
total			-10.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	57.9KB	58.2KB	+236.0B
`timelines`	313.0KB	318.2KB	+5.2KB
total			+5.4KB

Unknown metric groups

API count

id	before	after	diff
`securitySolution`	1329	1333	+4
`timelines`	938	959	+21
total			+25

API count missing comments

id	before	after	diff
`securitySolution`	1278	1282	+4
`timelines`	818	839	+21
total			+25

Non-exported public API item count

id	before	after	diff
`timelines`	25	24	-1

History

💔 Build #146175 failed 8f04def
💚 Build #146099 succeeded 0e4f7e1
💛 Build #145902 was flaky 1bee436
💔 Build #145696 failed b238fcc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

…08698) * use rac alerts bulk_update * cleanup * adds replace ALERT_STATUS with ALERT_WORKFLOW_STATUS and updates tests and adds logic for switching between signal.status and workflow status when updating alerts in .siem-signals * allow object and string types in query param, fixed single update api to use WORKFLOW_STATUS instead of ALERT_STATUS * adds additional integration test for when query is a DSL object in addtion to KQL string * optionally use fields api in requests if _source does not contain authz properties * integrate bulk update to all hook calls * adds fields support, fixes bug where we were writing to 'signals.status' and not { signals: {status }} in alerts client * clean up and fixes * fix a bug where we were not waiting for updates to complete when using ids param in alerts bulk update. Adds integration tests for detection engine testing update alerts with new alerts as data client routes * take index name from ecsData props * pr suggestions * some more type fixes * refactor and type fixes * snapshot updated * add status update actions to row context menu * refactor to use dispatch function in o11y actions * comment removed * bring alertConsumer back * bring indexNames back * check capabilities to show status update items Co-authored-by: Devin Hurley <devin.hurley@elastic.co>

kibanamachine · 2021-08-17T20:06:44Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…108992) * use rac alerts bulk_update * cleanup * adds replace ALERT_STATUS with ALERT_WORKFLOW_STATUS and updates tests and adds logic for switching between signal.status and workflow status when updating alerts in .siem-signals * allow object and string types in query param, fixed single update api to use WORKFLOW_STATUS instead of ALERT_STATUS * adds additional integration test for when query is a DSL object in addtion to KQL string * optionally use fields api in requests if _source does not contain authz properties * integrate bulk update to all hook calls * adds fields support, fixes bug where we were writing to 'signals.status' and not { signals: {status }} in alerts client * clean up and fixes * fix a bug where we were not waiting for updates to complete when using ids param in alerts bulk update. Adds integration tests for detection engine testing update alerts with new alerts as data client routes * take index name from ecsData props * pr suggestions * some more type fixes * refactor and type fixes * snapshot updated * add status update actions to row context menu * refactor to use dispatch function in o11y actions * comment removed * bring alertConsumer back * bring indexNames back * check capabilities to show status update items Co-authored-by: Devin Hurley <devin.hurley@elastic.co> Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co> Co-authored-by: Devin Hurley <devin.hurley@elastic.co>

semd and others added 26 commits August 10, 2021 21:06

use rac alerts bulk_update

49ebd28

cleanup

74e64b1

adds replace ALERT_STATUS with ALERT_WORKFLOW_STATUS and updates test…

73b97e3

…s and adds logic for switching between signal.status and workflow status when updating alerts in .siem-signals

allow object and string types in query param, fixed single update api…

d6094df

… to use WORKFLOW_STATUS instead of ALERT_STATUS

adds additional integration test for when query is a DSL object in ad…

1a7cfd4

…dtion to KQL string

merge master

ec8ada3

Merge branch 'tgrid-bulk-actions-rbac-update' into fix-bulk-update-api

f82720b

Merge pull request #1 from dhurley14/fix-bulk-update-api

18e1f8b

adds replace ALERT_STATUS with ALERT_WORKFLOW_STATUS and updates tests and adds logic for switching between signal.status and workflow status when updating alerts in .siem-signals

Merge remote-tracking branch 'upstream/master' into tgrid-bulk-action…

f91de3f

…s-rbac-update

optionally use fields api in requests if _source does not contain aut…

cae0960

…hz properties

integrate bulk update to all hook calls

918c4bd

adds fields support, fixes bug where we were writing to 'signals.stat…

7cbec10

…us' and not { signals: {status }} in alerts client

Merge pull request #2 from dhurley14/sergi_hotfix_bulk_update

dab6006

optionally use fields api in requests if _source does not contain authz properties

Merge branch 'tgrid-bulk-actions-rbac-update' of https://github.com/s…

120029e

…emd/kibana into tgrid-bulk-actions-rbac-update

clean up and fixes

7ef80cf

fix a bug where we were not waiting for updates to complete when usin…

df080e2

…g ids param in alerts bulk update. Adds integration tests for detection engine testing update alerts with new alerts as data client routes

take index name from ecsData props

1710bf3

Merge remote-tracking branch 'upstream/master' into tgrid-bulk-action…

22a85ea

…s-rbac-update

pr suggestions

8138fb6

some more type fixes

23e77f3

Merge pull request #3 from dhurley14/bulk_update_sec_sol_integration_…

ca20b19

…test fix a bug where we were not waiting for updates to complete when usin…

Merge remote-tracking branch 'upstream/master' into tgrid-bulk-action…

63e033c

…s-rbac-update

refactor and type fixes

d5c29fa

snapshot updated

5a09258

Merge remote-tracking branch 'upstream/master' into tgrid-bulk-action…

f4e6e52

…s-rbac-update

add status update actions to row context menu

b238fcc

semd commented Aug 16, 2021

View reviewed changes

x-pack/plugins/timelines/public/components/t_grid/body/index.tsx Outdated Show resolved Hide resolved

semd commented Aug 16, 2021

View reviewed changes

comment removed

1bee436

dplumlee approved these changes Aug 16, 2021

View reviewed changes

lukasolson added v8.0.0 and removed 8.0.0 labels Aug 17, 2021

michaelolo24 reviewed Aug 17, 2021

View reviewed changes

x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx Outdated Show resolved Hide resolved

michaelolo24 reviewed Aug 17, 2021

View reviewed changes

x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx Outdated Show resolved Hide resolved

bring alertConsumer back

97c4bed

mgiota mentioned this pull request Aug 17, 2021

[RAC] 7.15 Observability Checklist #107933

Closed

52 tasks

semd added 2 commits August 17, 2021 13:04

master conflicts solved

0e4f7e1

bring indexNames back

8f04def

kqualters-elastic approved these changes Aug 17, 2021

View reviewed changes

asnehalb mentioned this pull request Aug 17, 2021

[Security Solution][RAC] - 7.15 Checklist #108071

Closed

48 tasks

check capabilities to show status update items

fd0b3c3

semd enabled auto-merge (squash) August 17, 2021 17:50

XavierM approved these changes Aug 17, 2021

View reviewed changes

michaelolo24 reviewed Aug 17, 2021

View reviewed changes

michaelolo24 approved these changes Aug 17, 2021

View reviewed changes

semd merged commit b607f42 into elastic:master Aug 17, 2021

kibanamachine mentioned this pull request Aug 17, 2021

[7.x] [RAC][Observability] Add status update actions in row menu (#108698) #108992

Merged

This was referenced Aug 17, 2021

[RAC][Observability] Overflow actions popup stays open #108782

Closed

[RAC] Enable workflow status filtering #108215

Merged

dplumlee mentioned this pull request Aug 18, 2021

[Security Solution][RAC] Remove in-progress type guards once migration is complete #109030

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAC][Observability] Add status update actions in row menu #108698

[RAC][Observability] Add status update actions in row menu #108698

semd commented Aug 16, 2021 •

edited

Loading

elasticmachine commented Aug 16, 2021

semd Aug 16, 2021 •

edited

Loading

semd Aug 16, 2021

dplumlee left a comment

michaelolo24 left a comment

kibanamachine commented Aug 17, 2021

API count

API count missing comments

Non-exported public API item count

kibanamachine commented Aug 17, 2021

[RAC][Observability] Add status update actions in row menu #108698

[RAC][Observability] Add status update actions in row menu #108698

Conversation

semd commented Aug 16, 2021 • edited Loading

Summary

Checklist

elasticmachine commented Aug 16, 2021

semd Aug 16, 2021 • edited Loading

Choose a reason for hiding this comment

semd Aug 16, 2021

Choose a reason for hiding this comment

dplumlee left a comment

Choose a reason for hiding this comment

michaelolo24 left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 17, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

API count

API count missing comments

Non-exported public API item count

History

kibanamachine commented Aug 17, 2021

💚 Backport successful

semd commented Aug 16, 2021 •

edited

Loading

semd Aug 16, 2021 •

edited

Loading