[Canvas] Adds Tag Cloud support #106858

Kuznietsov · 2021-07-27T14:32:39Z

Completes a part of #101377.

At this PR TagCloud is added to Canvas.

Improvements:

Added full support of vis_dimension at tagcloud function. Now, accessor can be either index or name of the column.
Added validation of column index. If the index of the column is out of columns' boundary, vis_dimension throws an error.
Added TagCloud visualization to Canvas.
Added element Tag cloud to Charts category.
Added handling of empty data and displaying No results at Tag cloud.
Added a Storybook to expression_tagcloud.
Updated functional tests for tagcloud and metrics. Separated invalid data and empty data.
Updated vis_type_metrics types and added support of the accessor to be either index or name of the column.
Updated unit tests for expression_tagcloud and vis_type_metrics.

`Tag Cloud` at `Canvas`

`Tag Cloud` element

`Tag Cloud` renderer

`Tag Cloud` renderer with expression

`Tag Cloud` empty results at `Canvas`

Storybook at `vis_type_tagcloud`

Added check of accessor index, if such column exists at vis_dimension. Removed checks of column existance from TagCloudChart. Added test for accessing data by column name in addition to a column number. Updated tag_cloud element in Canvas. Fixed types. Removed almost all `any` and `as` types.

Added valid functional tests to metrics and tag_cloud. Fixed types of metrics_vis. Added handling of empty data at tag_cloud renderer.

…tion.

Kuznietsov · 2021-07-30T09:43:43Z

@elasticmachine merge upstream

# Conflicts: # src/plugins/chart_expressions/expression_tagcloud/common/expression_functions/tagcloud_function.test.ts # src/plugins/chart_expressions/expression_tagcloud/public/components/tagcloud_component.test.tsx # src/plugins/chart_expressions/expression_tagcloud/public/components/tagcloud_component.tsx # src/plugins/vis_type_tagcloud/kibana.json # src/plugins/vis_type_tagcloud/public/tag_cloud_fn.ts # src/plugins/vis_type_tagcloud/public/tag_cloud_vis_renderer.tsx # src/plugins/vis_type_tagcloud/public/types.ts # test/interpreter_functional/snapshots/baseline/tagcloud_empty_data.json # test/interpreter_functional/snapshots/baseline/tagcloud_invalid_data.json # test/interpreter_functional/snapshots/session/tagcloud_invalid_data.json

Kuznietsov · 2021-08-25T13:12:38Z

@elasticmachine merge upstream

Kuznietsov · 2021-08-30T06:06:07Z

@elasticmachine merge upstream

stratoula

This seems to work fine :)
Just 3 minor comments from my side

stratoula · 2021-08-30T10:30:09Z

...gins/chart_expressions/expression_tagcloud/public/expression_renderers/tagcloud_renderer.tsx


 export const tagcloudRenderer: (
  deps: ExpressioTagcloudRendererDependencies
 ) => ExpressionRenderDefinition<TagcloudRendererConfig> = ({ palettes }) => ({
  name: EXPRESSION_NAME,
-  displayName: strings.getDisplayName(),
-  help: strings.getHelpDescription(),


Is it safe to remove the help text here?

stratoula · 2021-08-30T10:30:22Z

...gins/chart_expressions/expression_tagcloud/public/expression_renderers/tagcloud_renderer.tsx


 export const tagcloudRenderer: (
  deps: ExpressioTagcloudRendererDependencies
 ) => ExpressionRenderDefinition<TagcloudRendererConfig> = ({ palettes }) => ({
  name: EXPRESSION_NAME,
-  displayName: strings.getDisplayName(),
-  help: strings.getHelpDescription(),
+  displayName: 'Tag Cloud visualization',


Shouldn't be localized?

stratoula · 2021-08-30T10:34:07Z

src/plugins/visualizations/common/expression_functions/vis_dimension.ts

-        ? args.accessor
-        : input.columns.find((c) => c.id === args.accessor);
+        ? getAccessorByIndex(args.accessor, input.columns)
+        : getAccessorById(args.accessor, input.columns);

    if (accessor === undefined) {
      throw new Error(
        i18n.translate('visualizations.function.visDimension.error.accessor', {


Let's also remove this translation from the translation files in order to be translated again

# Conflicts: # src/plugins/vis_types/metric/public/components/metric_vis_component.tsx # src/plugins/vis_types/metric/public/metric_vis_fn.ts # src/plugins/vis_types/metric/public/types.ts # src/plugins/vis_types/tagcloud/public/to_ast.test.ts # src/plugins/vis_types/tagcloud/public/types.ts

Kuznietsov · 2021-09-03T13:49:23Z

@stratoula, can you, please, review the current PR as if I've updated the code based on your nits. Thanks)

stratoula

LGTM, code review only. I have already tested it and my last commentes were mostly nits

Kuznietsov · 2021-09-06T06:00:16Z

@elasticmachine merge upstream

kibanamachine · 2021-09-06T08:13:35Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`canvas`	1065	1066	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`visualizations`	253	257	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1.6MB	1.6MB	+598.0B
`expressionTagcloud`	14.1KB	14.3KB	+142.0B
`visTypeMetric`	16.2KB	16.3KB	+134.0B
total			+874.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`expressionTagcloud`	12.5KB	12.4KB	-102.0B
`visTypeMetric`	22.2KB	22.2KB	-34.0B
`visualizations`	58.7KB	59.0KB	+298.0B
total			+162.0B

Unknown metric groups

API count

id	before	after	diff
`visualizations`	271	275	+4

History

💚 Build #150917 succeeded 9e78123
💔 Build #150906 failed f00fdf0fc77f4581d122a4162e9fa9c59fdf9502
💚 Build #149316 succeeded ddaf29c
💚 Build #148555 succeeded f7ec55e
💚 Build #148486 succeeded d6e02f5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

* Added `tagCloud` to canvas. * Added `icon` to the `tagCloud` element. * Added column name support at `tag_cloud`. * Added condition to `vis_dimension` not to pass invalid index. Added check of accessor index, if such column exists at vis_dimension. Removed checks of column existance from TagCloudChart. Added test for accessing data by column name in addition to a column number. Updated tag_cloud element in Canvas. Fixed types. Removed almost all `any` and `as` types. * Added test suites for `vis_dimension` function. * Added tests for DatatableColumn accessors at tag_cloud_fn and to_ast. * Refactored metrics, tagcloud and tests. Added valid functional tests to metrics and tag_cloud. Fixed types of metrics_vis. Added handling of empty data at tag_cloud renderer. * Added storybook ( still doesn't work ). * Fixed some mistakes. * Added working storybook with mocks. * Added clear storybook for tag_cloud_vis_renderer. * Updated the location of vis_dimension test after movement of the function. * Fixed unused type. * Fixed tests and added handling of the column name at `visualizations/**/*/prepare_log_table.ts` * Reduced the complexity of checking the accessor at `tag_cloud_chart.tsx` * Added comments at unclear places of code. * Added the logic for disabling elements for renderers from disabled plugins. * removed garbage from `kibana.yml`. * Fixed element_strings.test error. * Made changes, based on nits. * Fixed mistake. * Removed `disabled` flag for `expression_*` plugins. * recovered lost comments at the unclear places. * removed dead code. * fixed test errors. * Fixed test error, I hope. * fixed more tests. * fixed code, based on nits. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-09-06T08:16:40Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Added `tagCloud` to canvas. * Added `icon` to the `tagCloud` element. * Added column name support at `tag_cloud`. * Added condition to `vis_dimension` not to pass invalid index. Added check of accessor index, if such column exists at vis_dimension. Removed checks of column existance from TagCloudChart. Added test for accessing data by column name in addition to a column number. Updated tag_cloud element in Canvas. Fixed types. Removed almost all `any` and `as` types. * Added test suites for `vis_dimension` function. * Added tests for DatatableColumn accessors at tag_cloud_fn and to_ast. * Refactored metrics, tagcloud and tests. Added valid functional tests to metrics and tag_cloud. Fixed types of metrics_vis. Added handling of empty data at tag_cloud renderer. * Added storybook ( still doesn't work ). * Fixed some mistakes. * Added working storybook with mocks. * Added clear storybook for tag_cloud_vis_renderer. * Updated the location of vis_dimension test after movement of the function. * Fixed unused type. * Fixed tests and added handling of the column name at `visualizations/**/*/prepare_log_table.ts` * Reduced the complexity of checking the accessor at `tag_cloud_chart.tsx` * Added comments at unclear places of code. * Added the logic for disabling elements for renderers from disabled plugins. * removed garbage from `kibana.yml`. * Fixed element_strings.test error. * Made changes, based on nits. * Fixed mistake. * Removed `disabled` flag for `expression_*` plugins. * recovered lost comments at the unclear places. * removed dead code. * fixed test errors. * Fixed test error, I hope. * fixed more tests. * fixed code, based on nits. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com>

Added tagCloud to canvas.

8a7ecc7

Kuznietsov added WIP Work in progress Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 Feature:Canvas v7.15.0 labels Jul 27, 2021

Kuznietsov requested review from crob611 and alexwizp July 27, 2021 14:32

Kuznietsov self-assigned this Jul 27, 2021

Kuznietsov changed the title ~~[Canvas] TagCloud~~ [WIP] [Canvas] TagCloud Jul 27, 2021

Kuznietsov added 4 commits July 27, 2021 17:52

Reverted changes and added new tagCloud expression

3030a30

Added translations to element.

f5bbd80

Fixed height of the tagCloud container.

1f34fae

Added icon to the tagCloud element.

f363691

Kuznietsov changed the title ~~[WIP] [Canvas] TagCloud~~ [Canvas] TagCloud Jul 28, 2021

Kuznietsov removed the WIP Work in progress label Jul 28, 2021

Kuznietsov added 13 commits July 28, 2021 16:44

commit small changes.

ceea7e8

Added column name support at tag_cloud.

407381c

Added condition to vis_dimension not to pass invalid index.

6c10a6d

Added test suites for vis_dimension function.

4e98aad

Added tests for DatatableColumn accessors at tag_cloud_fn and to_ast.

6b08a08

Refactored metrics, tagcloud and tests.

41b21d7

Added valid functional tests to metrics and tag_cloud. Fixed types of metrics_vis. Added handling of empty data at tag_cloud renderer.

Added storybook ( still doesn't work ).

67b7012

Fixed some mistakes.

11fbd3c

Added working storybook with mocks.

0a137b0

Added clear storybook for tag_cloud_vis_renderer.

96689fe

Merge branch 'master' into tag_cloud_canvas

6fa3cdb

Updated the location of vis_dimension test after movement of the func…

f71321a

…tion.

Kuznietsov added 8 commits August 23, 2021 17:11

Fixed mistake.

ae66a5b

Removed disabled flag for expression_* plugins.

eb75f35

recovered lost comments at the unclear places.

da58c1e

removed dead code.

6f6ef3c

fixed test errors.

dc8e4af

Fixed test error, I hope.

1a5453f

fixed more tests.

d6e02f5

Merge branch 'master' into tag_cloud_canvas

f7ec55e

Merge branch 'master' into tag_cloud_canvas

ddaf29c

stratoula reviewed Aug 30, 2021

View reviewed changes

Kuznietsov force-pushed the tag_cloud_canvas branch from ddaf29c to 1501557 Compare September 3, 2021 11:23

Kuznietsov requested a review from a team as a code owner September 3, 2021 11:23

fixed code, based on nits.

08dcd3f

Kuznietsov force-pushed the tag_cloud_canvas branch from 42308d8 to 08dcd3f Compare September 3, 2021 11:44

stratoula approved these changes Sep 3, 2021

View reviewed changes

Merge branch 'master' into tag_cloud_canvas

bb879e0

Kuznietsov enabled auto-merge (squash) September 6, 2021 06:28

Kuznietsov merged commit eef094b into elastic:master Sep 6, 2021

kibanamachine mentioned this pull request Sep 6, 2021

[7.x] [Canvas] TagCloud (#106858) #111257

Merged

timroes changed the title ~~[Canvas] TagCloud~~ [Canvas] Adds Tag Cloud support Oct 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Canvas] Adds Tag Cloud support #106858

[Canvas] Adds Tag Cloud support #106858

Kuznietsov commented Jul 27, 2021 •

edited

Loading

Kuznietsov commented Jul 30, 2021

Kuznietsov commented Aug 25, 2021

Kuznietsov commented Aug 30, 2021

stratoula left a comment

stratoula Aug 30, 2021

Kuznietsov Sep 3, 2021

stratoula Aug 30, 2021

Kuznietsov Sep 3, 2021

stratoula Aug 30, 2021

Kuznietsov Sep 3, 2021

Kuznietsov commented Sep 3, 2021

stratoula left a comment

Kuznietsov commented Sep 6, 2021

kibanamachine commented Sep 6, 2021

API count

kibanamachine commented Sep 6, 2021

[Canvas] Adds Tag Cloud support #106858

[Canvas] Adds Tag Cloud support #106858

Conversation

Kuznietsov commented Jul 27, 2021 • edited Loading

Completes a part of #101377.

Tag Cloud at Canvas

Tag Cloud element

Tag Cloud renderer

Tag Cloud renderer with expression

Tag Cloud empty results at Canvas

Storybook at vis_type_tagcloud

Kuznietsov commented Jul 30, 2021

Kuznietsov commented Aug 25, 2021

Kuznietsov commented Aug 30, 2021

stratoula left a comment

Choose a reason for hiding this comment

stratoula Aug 30, 2021

Choose a reason for hiding this comment

Kuznietsov Sep 3, 2021

Choose a reason for hiding this comment

stratoula Aug 30, 2021

Choose a reason for hiding this comment

Kuznietsov Sep 3, 2021

Choose a reason for hiding this comment

stratoula Aug 30, 2021

Choose a reason for hiding this comment

Kuznietsov Sep 3, 2021

Choose a reason for hiding this comment

Kuznietsov commented Sep 3, 2021

stratoula left a comment

Choose a reason for hiding this comment

Kuznietsov commented Sep 6, 2021

kibanamachine commented Sep 6, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kibanamachine commented Sep 6, 2021

💚 Backport successful

Kuznietsov commented Jul 27, 2021 •

edited

Loading

`Tag Cloud` at `Canvas`

`Tag Cloud` element

`Tag Cloud` renderer

`Tag Cloud` renderer with expression

`Tag Cloud` empty results at `Canvas`

Storybook at `vis_type_tagcloud`