Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User Experience App] Fix ux app env filter #105918

Merged
merged 5 commits into from
Jul 16, 2021
Merged

[User Experience App] Fix ux app env filter #105918

merged 5 commits into from
Jul 16, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jul 16, 2021 •
edited
Loading

Fix the bug found in test plan of #102069

Where environment was being applied in es query in both conditions of must and must_not.

Also made environment filter work better for longer values with increasing max-width.

Added a test for the utility.

@shahzad31 shahzad31 self-assigned this Jul 16, 2021
@shahzad31 shahzad31 added v7.14.0 v8.0.0 v7.15.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 16, 2021
@shahzad31 shahzad31 marked this pull request as ready for review July 16, 2021 07:29
@shahzad31 shahzad31 requested a review from a team as a code owner July 16, 2021 07:29
@shahzad31 shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jul 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

justinkambic
justinkambic approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixed!

Jul-16-2021 13-11-30

@justinkambic justinkambic mentioned this pull request Jul 16, 2021
Closed
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 16, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 merged commit 966f81e into elastic:master Jul 16, 2021
@shahzad31 shahzad31 deleted the fix-env-ux-filter branch July 16, 2021 17:28
@kibanamachine kibanamachine mentioned this pull request Jul 16, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 16, 2021
@shahzad31 @kibanamachine
[User Experience App] Fix ux app env filter (elastic#105918)
af6678f
@kibanamachine kibanamachine mentioned this pull request Jul 16, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 16, 2021
@shahzad31 @kibanamachine
[User Experience App] Fix ux app env filter (elastic#105918)
8b82007
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 16, 2021
@kibanamachine @shahzad31
[User Experience App] Fix ux app env filter (#105918) (#106000)
9afbdcc 
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 16, 2021
@kibanamachine @shahzad31
[User Experience App] Fix ux app env filter (#105918) (#106001)
b26051d 
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
@shahzad31 shahzad31 restored the fix-env-ux-filter branch September 23, 2021 19:27
@shahzad31 shahzad31 deleted the fix-env-ux-filter branch November 9, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @elasticmachine @kibanamachine @justinkambic