Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup index pattern list fixes #105458

Merged
merged 10 commits into from
Jul 14, 2021

Conversation

mattkime
Copy link
Contributor

Summary

Fix rendering of rollup index pattern field info in index pattern management.

Screen Shot 2021-07-13 at 7 16 59 AM

Screen Shot 2021-07-13 at 7 17 39 AM

@mattkime mattkime requested a review from a team as a code owner July 13, 2021 15:52
@mattkime mattkime added SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Rollups auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:AppServices v7.14.0 v7.15.0 v8.0.0 labels Jul 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime mattkime requested a review from Dosant July 13, 2021 23:08
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 3255 3257 +2

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
data 108 106 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 840.0KB 840.0KB +9.0B
indexPatternManagement 19.1KB 19.2KB +100.0B
total +109.0B
Unknown metric groups

API count

id before after diff
data 3821 3823 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested, LGTM, thanks for patching the test

@mattkime mattkime merged commit 320eaea into elastic:master Jul 14, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 14, 2021
* fix index pattern field list and improve typescript
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 14, 2021
* fix index pattern field list and improve typescript
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.14
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 14, 2021
* fix index pattern field list and improve typescript

Co-authored-by: Matthew Kime <matt@mattki.me>
kibanamachine added a commit that referenced this pull request Jul 14, 2021
* fix index pattern field list and improve typescript

Co-authored-by: Matthew Kime <matt@mattki.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Rollups release_note:skip Skip the PR/issue when compiling release notes SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants