Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Add more functional tests for Gauge and TopN #105361

Merged
merged 8 commits into from
Jul 21, 2021
Merged

[TSVB] Add more functional tests for Gauge and TopN #105361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
81b5648
[TSVB] Add more functional tests for Gauge and TopN
DianaDerevyankina Jul 12, 2021
065d834
Update visual_builder_page.ts
DianaDerevyankina Jul 13, 2021
cdf14f8
Merge branch 'master' into TSVB-functional-tests-gauge-topN
DianaDerevyankina Jul 19, 2021
a28ad13
Update functions related to gauge color and filter ratio numerator in…
DianaDerevyankina Jul 19, 2021
cc2a239
Merge branch 'master' into TSVB-functional-tests-gauge-topN
kibanamachine Jul 20, 2021
cb77140
Update visual_builder_page and add some more test subjects
DianaDerevyankina Jul 20, 2021
f094c44
Merge branch 'master' into TSVB-functional-tests-gauge-topN
kibanamachine Jul 21, 2021
2d36bba
Update _tsvb_chart.ts
DianaDerevyankina Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/plugins/vis_type_timeseries/public/application/visualizations/views/gauge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,15 @@ export class Gauge extends Component {
ref={(el) => (this.inner = el)}
style={styles.inner}
>
<div className="tvbVisGauge__label" ref="title">
<div className="tvbVisGauge__label" ref="title" data-test-subj="gaugeLabel">
{title}
</div>
<div className="tvbVisGauge__value" style={styles.valueColor} ref="label">
<div
className="tvbVisGauge__value"
style={styles.valueColor}
ref="label"
data-test-subj="gaugeValue"
>
{formatter(value)}
</div>
{additionalLabel}
Expand All @@ -124,10 +129,15 @@ export class Gauge extends Component {
ref={(el) => (this.inner = el)}
style={styles.inner}
>
<div className="tvbVisGauge__value" style={styles.valueColor} ref="label">
<div
className="tvbVisGauge__value"
style={styles.valueColor}
ref="label"
data-test-subj="gaugeValue"
>
{formatter(value)}
</div>
<div className="tvbVisGauge__label" ref="title">
<div className="tvbVisGauge__label" ref="title" data-test-subj="gaugeLabel">
{title}
</div>
{additionalLabel}
Expand Down
12 changes: 8 additions & 4 deletions src/plugins/vis_type_timeseries/public/application/visualizations/views/gauge_vis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,19 @@ export class GaugeVis extends Component {
if (type === 'half') {
svg = (
<svg width={120.72} height={78.72}>
<circle {...props.circleBackground} style={styles.innerLine} />
<circle {...props.circle} style={styles.gaugeLine} />
<circle
{...props.circleBackground}
style={styles.innerLine}
data-test-subj="gaugeCircleInner"
/>
<circle {...props.circle} style={styles.gaugeLine} data-test-subj="gaugeCircle" />
</svg>
);
} else {
svg = (
<svg width={120.72} height={120.72}>
<circle {...props.circleBackground} />
<circle {...props.circle} />
<circle {...props.circleBackground} data-test-subj="gaugeCircleInner" />
<circle {...props.circle} data-test-subj="gaugeCircle" />
</svg>
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/vis_type_timeseries/public/application/visualizations/views/top_n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export class TopN extends Component {
</td>
<td width="100%" className="tvbVisTopN__bar">
<div className="tvbVisTopN__innerBar" style={styles.innerBar}>
<div style={styles.innerBarValue} />
<div style={styles.innerBarValue} data-test-subj="topNInnerBar" />
</div>
</td>
<td className="tvbVisTopN__value" data-test-subj="tsvbTopNValue">
Expand Down
Loading