[CTI] shortens large numbers on Dashboard Link Panel #105269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
rylnd
approved these changes
Jul 12, 2021
| */ | ||
| export const shortenCountIntoString = (count: number): string => { | ||
| if (count < 10000) { | ||
| return count.toString(); |
There was a problem hiding this comment.
Should we use .toLocaleString here?
There was a problem hiding this comment.
actually for numbers under 10000 I believe we don't want to see 9,999 vs 9.999, just 9999 @yiyangliu9286
| if (count < 10000) { | ||
| return count.toString(); | ||
| } | ||
| const si = [ |
There was a problem hiding this comment.
Nit: there are a lot of one- or two-character variables in this function; more declarative names might help with legibility here. E.g. magnitude and unit instead of v and s
Comment on lines
26
to
31
| let i; | ||
| for (i = si.length - 1; i > 0; i--) { | ||
| if (count >= si[i].v) { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
You could reverse the above array to simplify this logic:
Suggested change
| let i; | |
| for (i = si.length - 1; i > 0; i--) { | |
| if (count >= si[i].v) { | |
| break; | |
| } | |
| } | |
| const { magnitude, unit } = abbreviations.find((abbreviation) => count >= abbreviation.magnitude); |
| } | ||
|
|
||
| return ( | ||
| toFixedWithoutRounding(count / si[i].v, 1).replace(/\.0+$|(\.[0-9]*[1-9])0+$/, '$1') + si[i].s |
There was a problem hiding this comment.
The @elastic/numeral package might be able to do some of this formatting for you, if you haven't yet explored that option.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @ecezalp |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 13, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jul 13, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 13, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (292 commits) bring back KQL autocomplete in timeline + fix last updated (elastic#105380) [Maps] Change TOC pop-up wording to reflect filter change, not search bar change (elastic#105163) Updating urls to upstream elastic repo (elastic#105250) [Maps] Move new vector layer wizard card down (elastic#104797) Exclude registering the cases feature if not enabled (elastic#105292) [Uptime] Alerts - Monitor status alert - check monitor status by monitor.timespan (elastic#104541) updated UI copy (elastic#105184) Log a warning when documents of unknown types are detected during migration (elastic#105213) [Logs UI] Register log threshold rule as lifecycle rule (elastic#104341) [Ingest pipelines] add network direction processor (elastic#103436) [Console] Autocomplete definitions (manual backport) (elastic#105086) [Security Solution] User can make Exceptions for Memory protection alerts (elastic#102196) [Lens] Formula: add validation for multiple field/metrics (elastic#104092) Removing async from file upload and data visualizer plugins start lifecycle (elastic#105197) Fix error when validating the form with non blocking validations (elastic#103629) [ML] Fix "View by" swim lane with applied filter and sorting by score (elastic#105217) Update dependency @elastic/charts to v32 (elastic#104625) [CTI] shortens large numbers on Dashboard Link Panel (elastic#105269) [Security Solution][Endpoint][Host Isolation] Fixes bug to remove excess host metadata status toasts on non user initiated errors (elastic#105331) [Cases] Fix pushing alerts count on every push to external service (elastic#105030) ... # Conflicts: # x-pack/plugins/reporting/common/types.ts
ecezalp
added a commit
to ecezalp/kibana
that referenced
this pull request
Jul 19, 2021
# Conflicts: # x-pack/plugins/security_solution/public/overview/components/overview_cti_links/threat_intel_panel_view.tsx
ecezalp
added a commit
that referenced
this pull request
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Showing: ${x} eventstoShowing: ${x} indicatorsChecklist