[5.x][status api] opt in to v6 metrics #10481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
suggested changes
Feb 23, 2017
src/server/status/index.js
Outdated
| metrics: kbnServer.v6Metrics | ||
| }); | ||
| } | ||
|
|
||
| return reply({ |
There was a problem hiding this comment.
This return should be legacy format with without the nested version information. Metrics also needs to be of the legacy format.
src/server/status/metrics.js
Outdated
| kbnServer.metrics = new Samples(12); | ||
|
|
||
| server.plugins['even-better'].monitor.on('ops', function (event) { | ||
| kbnServer.v6Metrics = getV6Metrics({ event, config }); |
There was a problem hiding this comment.
What are your thoughts on swapping this, creating kbnServer.legacyMetrics. Reason being is we are exposing the cgroup information via this interface.
src/server/config/schema.js
Outdated
| @@ -148,7 +148,8 @@ module.exports = () => Joi.object({ | |||
| }).default(), | |||
|
|
|||
| status: Joi.object({ | |||
| allowAnonymous: Joi.boolean().default(false) | |||
| allowAnonymous: Joi.boolean().default(false), | |||
| v6Api: Joi.boolean().default(true) | |||
There was a problem hiding this comment.
We should default this to false.
|
jenkins, test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an opt-in backport of #10180, returning only the latest metrics from the status api. It can be enabled by setting
status.v6ApiFormat: truein kibana.yml