Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Expressions] Update expressions public API to expose partial results support (#102403) #104210

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Jul 1, 2021

Backports the following commits to 7.x:

… support (elastic#102403)

* Add partial result flag to the execution result
* Update expressions plugin run method to return observable
* Update data getter in the execution contract to return observable
* Update the expression loader to take into account the partial results flag
@dokmic dokmic added the backport label Jul 1, 2021
@dokmic dokmic enabled auto-merge (squash) July 1, 2021 20:57
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressions 1534 1535 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.2MB 1.2MB +222.0B
visTypeTimeseries 1007.3KB 1007.3KB +68.0B
total +290.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 210.2KB 211.2KB +1.0KB
Unknown metric groups

API count

id before after diff
expressions 1962 1966 +4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dokmic dokmic merged commit c73e13d into elastic:7.x Jul 1, 2021
@dokmic dokmic deleted the backport/7.x/pr-102403 branch July 2, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants