Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix multiline display in classic table #103499

Merged
merged 10 commits into from
Jul 8, 2021
Merged

[Discover] Fix multiline display in classic table #103499

merged 10 commits into from
Jul 8, 2021

Conversation

kertal
Copy link
Member

@kertal kertal commented Jun 28, 2021 •
edited
Loading

Summary

This PR inverts a CSS change (in #83891) that broke the display of multi line strings in Discover classic table.

Before this PR, text containing multi lines looked like this:

Applying the changes of this PR, newlines look fine again

Fixes #97952

Checklist

@kertal kertal requested a review from a team as a code owner June 28, 2021 15:06
@kertal kertal marked this pull request as draft June 28, 2021 15:06
@kertal kertal self-assigned this Jun 28, 2021
@kertal kertal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v7.13.3 :KibanaApp/fix-it-week release_note:fix labels Jun 28, 2021
@kertal
Copy link
Member Author

kertal commented Jun 28, 2021

@elasticmachine merge upstream

@kertal kertal marked this pull request as ready for review June 30, 2021 10:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Merge branch 'kertal-pr-2021-06-25-discover-restore-multiline-data-di…
534af13 
…splay' of github.com:kertal/kibana into kertal-pr-2021-06-25-discover-restore-multiline-data-display
@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
@kertal kertal requested a review from timroes July 1, 2021 13:54
@timroes timroes added the v7.14.0 label Jul 1, 2021
@kertal kertal requested review from dimaanj and majagrubic and removed request for majagrubic July 1, 2021 13:55
@kertal
Copy link
Member Author

kertal commented Jul 5, 2021

@elasticmachine merge upstream

@kertal
Copy link
Member Author

kertal commented Jul 6, 2021

@elasticmachine merge upstream

@timroes timroes removed the v7.13.3 label Jul 6, 2021
@kertal
Copy link
Member Author

kertal commented Jul 6, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 422.2KB 422.6KB +392.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

andreadelrio
andreadelrio approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

timroes
timroes approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome Linux, works as expected. Code LGTM

@kertal kertal added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 8, 2021
flash1293
flash1293 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Safari and Firefox, works as expected

@kertal kertal merged commit b589fe5 into elastic:master Jul 8, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
@kertal @kibanamachine
[Discover] Fix multiline display in classic table (elastic#103499)
3ef54b4 
* Restore CSS that broke multiline display

* Add functional test
@kibanamachine kibanamachine mentioned this pull request Jul 8, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
@kertal @kibanamachine
[Discover] Fix multiline display in classic table (elastic#103499)
f20728d 
* Restore CSS that broke multiline display

* Add functional test
@kibanamachine kibanamachine mentioned this pull request Jul 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 8, 2021
@kibanamachine @kertal
[Discover] Fix multiline display in classic table (#103499) (#104823)
d449412 
* Restore CSS that broke multiline display

* Add functional test

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 8, 2021
@kibanamachine @kertal
[Discover] Fix multiline display in classic table (#103499) (#104824)
32a55c2 
* Restore CSS that broke multiline display

* Add functional test

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@flash1293 flash1293 flash1293 approved these changes

@andreadelrio andreadelrio andreadelrio approved these changes

@dimaanj dimaanj Awaiting requested review from dimaanj

@ryankeairns ryankeairns Awaiting requested review from ryankeairns

Assignees

@kertal kertal

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Support multiline content in document table
7 participants
@kertal @elasticmachine @kibanamachine @timroes @flash1293 @andreadelrio @spalger