[TSVB] Fix TSVB is not reporting all categories of Elasticsearch error #102926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
commented
Jun 22, 2021
| @@ -147,16 +145,6 @@ function TimeseriesVisualization({ | |||
| handlers.done(); | |||
| }); | |||
|
|
|||
| // Show the error panel | |||
| const error = isVisSeriesData(visData) && visData[model.id]?.error; | |||
There was a problem hiding this comment.
dead code, it will never be called
alexwizp
commented
Jun 22, 2021
| @@ -159,8 +159,8 @@ export class VisEditor extends Component<TimeseriesEditorProps, TimeseriesEditor | |||
| this.setState({ autoApply: event.target.checked }); | |||
| }; | |||
|
|
|||
| onDataChange = ({ visData }: { visData: TimeseriesVisData }) => { | |||
There was a problem hiding this comment.
in case of error it's null with an error in console
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
VladLasitsa
reviewed
Jun 23, 2021
VladLasitsa
approved these changes
Jun 24, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @alexwizp |
stratoula
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Code LGTM, I tested some scenarios and I think that it works fine. Many errors that were not displayed (TSVB appeared with No results) are reported now. I think that this is very important for our users' experience!
@wylieconlon I would appreciate it if you could also take a look!
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jun 30, 2021
elastic#102926) * [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error Closes: elastic#94182 * move validation to server side Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
Jun 30, 2021
#102926) (#103840) * [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error Closes: #94182 * move validation to server side Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 30, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (178 commits) [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028) [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850) [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852) Allow zero (0) to unset unenroll_timeout field (elastic#103790) [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717) [Query] Es query/field base (elastic#103177) Remove add data button from nav (elastic#103810) Fix telemetry advanced setting style (elastic#103838) [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690) [APM] use conventional error rate color for correlations (elastic#103500) Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171) [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663) fix too many rernders (elastic#103672) [APM] Add “Analyze Data” button (elastic#103485) [Lens] Fix value popover spacing (elastic#103081) [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926) [SECURITY] Adds security links to doc link service (elastic#102676) Update dependency @elastic/charts to v31 (elastic#102078) [Security Solution][CTI] Investigation time enrichment UI (elastic#103383) Adds ECS guide to doc links service (elastic#102246) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #94182, Closes: #74541
Summary
TSVB is not reporting all categories of Elasticsearch error
Steps to reproduce:
Go to the Kibana advanced settings and increase the
metrics:max_bucketslimit from2000to100000, which is higher than Elasticsearch allowsGo back to TSVB and choose "Last 30 days" with an interval of 30 seconds.
After issuing the query, TSVB will show a "No results" screen, but no error message. The error is completely silent.
Screen: