[6.8] Force-upgrade all versions of minimist to ^1.2.5

[watson]

A similar thing have been done in 7.x (see #60284), and it should be safe to do the same thing here.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 1bc8ead

History

• 💔 Build #131424 failed d3f7f60

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[jportner]

Just for posterity, in the current 6.8 branch:

% yarn why minimist    
yarn why v1.22.10
[1/4] 🤔  Why do we have the module "minimist"...?
[2/4] 🚚  Initialising dependency graph...
warning Resolution field "growl@1.10.5" is incompatible with requested version "growl@1.9.2"
warning Resolution field "yargs-parser@5.0.0-security.0" is incompatible with requested version "yargs-parser@^5.0.0"
warning Resolution field "trim@0.0.3" is incompatible with requested version "trim@0.0.1"
warning Resolution field "growl@1.10.5" is incompatible with requested version "growl@1.9.2"
warning Resolution field "schema-utils@1.0.0" is incompatible with requested version "schema-utils@^0.3.0"
warning Resolution field "trim@0.0.3" is incompatible with requested version "trim@0.0.1"
warning Resolution field "@types/node@10.12.27" is incompatible with requested version "@types/node@^14.14.10"
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "minimist@1.2.5"
info Has been hoisted to "minimist"
info Reasons this module exists
   - "workspace-aggregator-9674edcd-0935-455f-abe8-f8cee80cf7b6" depends on it
   - Hoisted from "_project_#json5#minimist"
   - Hoisted from "_project_#ts-node#minimist"
   - Hoisted from "_project_#karma-mocha#minimist"
   - Hoisted from "_project_#handlebars#minimist"
   - Hoisted from "_project_#dateformat#meow#minimist"
   - Hoisted from "_project_#@kbn#pm#strong-log-transformer#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yeoman-generator#minimist"
   - Hoisted from "_project_#less#mkdirp#minimist"
   - Hoisted from "_project_#nock#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#pm#mkdirp#minimist"
   - Hoisted from "_project_#babel-loader#mkdirp#minimist"
   - Hoisted from "_project_#babel-register#mkdirp#minimist"
   - Hoisted from "_project_#cache-loader#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#es#mkdirp#minimist"
   - Hoisted from "_project_#backport#mkdirp#minimist"
   - Hoisted from "_project_#eslint#mkdirp#minimist"
   - Hoisted from "_project_#node-sass#mkdirp#minimist"
   - Hoisted from "_project_#ts-node#mkdirp#minimist"
   - Hoisted from "_project_#extract-zip#mkdirp#minimist"
   - Hoisted from "_project_#webpack#mkdirp#minimist"
   - Hoisted from "_project_#x-pack#mapbox-gl#geojson-rewind#minimist"
   - Hoisted from "_project_#x-pack#gulp-mocha#gulp-util#minimist"
   - Hoisted from "_project_#jest-cli#jest-haste-map#sane#minimist"
   - Hoisted from "_project_#@kbn#i18n#@babel#core#json5#minimist"
   - Hoisted from "_project_#fsevents#node-pre-gyp#rc#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yo#tabtab#minimist"
   - Hoisted from "_project_#karma-coverage#istanbul#mkdirp#minimist"
   - Hoisted from "_project_#tar#fstream#mkdirp#minimist"
   - Hoisted from "_project_#sass-lint#eslint#mkdirp#minimist"
   - Hoisted from "_project_#node-sass#node-gyp#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yeoman-generator#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#i18n#@babel#cli#mkdirp#minimist"
   - Hoisted from "_project_#terser-webpack-plugin#cacache#mkdirp#minimist"
   - Hoisted from "_project_#jest-cli#istanbul-api#mkdirp#minimist"
   - Hoisted from "_project_#jest-cli#istanbul-lib-source-maps#mkdirp#minimist"
   - Hoisted from "_project_#jest-cli#jest-snapshot#mkdirp#minimist"
   - Hoisted from "_project_#jest-cli#jest-util#mkdirp#minimist"
   - Hoisted from "_project_#re2#node-gyp#mkdirp#minimist"
   - Hoisted from "_project_#fsevents#node-pre-gyp#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#pm#cmd-shim#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yo#yosay#taketalk#minimist"
   - Hoisted from "_project_#@kbn#plugin-generator#sao#yarn-install#cac#minimist"
   - Hoisted from "_project_#@kbn#plugin-generator#sao#cac#minimost#minimist"
   - Hoisted from "_project_#jest-cli#jest-haste-map#sane#watch#minimist"
   - Hoisted from "_project_#makelogs#update-notifier#configstore#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yeoman-generator#mem-fs-editor#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#interpreter#copy-webpack-plugin#cacache#mkdirp#minimist"
   - Hoisted from "_project_#jest-cli#istanbul-api#istanbul-lib-report#mkdirp#minimist"
   - Hoisted from "_project_#terser-webpack-plugin#cacache#move-concurrently#mkdirp#minimist"
   - Hoisted from "_project_#@elastic#datemath#babel-cli#output-file-sync#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#yo#tabtab#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#webpack-dev-server#webpack-dev-middleware#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#ui-framework#webpack-dev-server#portfinder#mkdirp#minimist"
   - Hoisted from "_project_#x-pack#babel-plugin-inline-react-svg#svgo#mkdirp#minimist"
   - Hoisted from "_project_#x-pack#turf#turf-isolines#turf-grid#turf-point#minimist"
   - Hoisted from "_project_#x-pack#pdfmake#linebreak#brfs#quote-stream#minimist"
   - Hoisted from "_project_#terser-webpack-plugin#cacache#move-concurrently#copy-concurrently#mkdirp#minimist"
   - Hoisted from "_project_#@kbn#plugin-generator#sao#download-git-repo#download#mkdirp#minimist"
   - Hoisted from "_project_#eslint#file-entry-cache#flat-cache#write#mkdirp#minimist"
info Disk size without dependencies: "104KB"
info Disk size with unique dependencies: "104KB"
info Disk size with transitive dependencies: "104KB"
info Number of shared dependencies: 0
=> Found "mkdirp#minimist@0.0.8"
info This module exists because "_project_#mkdirp" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "72KB"
info Disk size with transitive dependencies: "72KB"
info Number of shared dependencies: 0
=> Found "mapbox-gl#minimist@0.0.8"
info This module exists because "_project_#x-pack#mapbox-gl" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "72KB"
info Disk size with transitive dependencies: "72KB"
info Number of shared dependencies: 0
=> Found "gonzales-pe-sl#minimist@1.1.3"
info This module exists because "_project_#sass-lint#gonzales-pe-sl" depends on it.
info Disk size without dependencies: "92KB"
info Disk size with unique dependencies: "92KB"
info Disk size with transitive dependencies: "92KB"
info Number of shared dependencies: 0
=> Found "glob-all#minimist@0.1.0"
info Reasons this module exists
   - "_project_#glob-all#yargs" depends on it
   - Hoisted from "_project_#glob-all#yargs#minimist"
info Disk size without dependencies: "80KB"
info Disk size with unique dependencies: "80KB"
info Disk size with transitive dependencies: "80KB"
info Number of shared dependencies: 0
=> Found "optimist#minimist@0.0.10"
info This module exists because "_project_#makelogs#optimist" depends on it.
info Disk size without dependencies: "80KB"
info Disk size with unique dependencies: "80KB"
info Disk size with transitive dependencies: "80KB"
info Number of shared dependencies: 0
=> Found "sharkdown#minimist@0.0.5"
info This module exists because "_project_#x-pack#mapbox-gl#geojson-rewind#sharkdown" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "72KB"
info Disk size with transitive dependencies: "72KB"
info Number of shared dependencies: 0
✨  Done in 1.28s.

I know in the linked PR you upgraded geojson-rewind from 0.4.1 to 0.5.0. The 6.8 branch is currently using version 0.3.0 though, so idk if it's safe to make the same upgrade.

[watson]

@jportner the geojson-rewind we upgraded in 7.x was actually @mapbox/geojson-rewind. The geojson-rewind package in 6.8 does not have anything newer than what we already got, so we can't upgrade it as it's not a direct dependency (as it is in 7.x), but a sub-dependency of mapbox-gl

Update: Ok, I could actually update mapbox-gl from v0.52.0 to v0.53.1 (anything higher than that version will introduce breaking changes). This upgrade did change the dependency from geojson-rewind to @mapbox/geojson-rewind version 0.4.1. However, since it's still an indirect dependency I can't upgrade it to v0.5.0. So this version still depends on sharkdown and hence also the old version of minimist.

Update 2: Because I can't safely get to @mapbox/geojson-rewind version 0.5.0, I'm just going to merge this as-is.