Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] adds WrapSequences method (RAC) #102106

Merged
merged 13 commits into from
Jun 17, 2021
Merged

[Security Solution] adds WrapSequences method (RAC) #102106

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
afeacc5
adds WrapSequences method
ecezalp Jun 14, 2021
d0ac8bc
remove isRuleRegistryEnabled flag for now
ecezalp Jun 14, 2021
0ecb444
remove leftover isRuleRegistryEnabled flags
ecezalp Jun 14, 2021
0194fb3
removes filterDuplicateSignals from wrapSequences
ecezalp Jun 15, 2021
4ae8dd4
Merge branch 'master' into wrap-sequences
kibanamachine Jun 15, 2021
e60b369
removes unknown from wrapHits type, refactors wrapSequencesFactory
ecezalp Jun 16, 2021
8081fa0
Merge branch 'master' into wrap-sequences
ecezalp Jun 16, 2021
02056f3
fix merge error
ecezalp Jun 16, 2021
adc7aa7
fix broken api test in generating_signals
ecezalp Jun 17, 2021
c1b57f6
Merge branch 'master' into wrap-sequences
kibanamachine Jun 17, 2021
65bcd0f
second attempt at fixing generating_signals by removing hardcoded ids
ecezalp Jun 17, 2021
efa0b3f
Merge branch 'master' into wrap-sequences
kibanamachine Jun 17, 2021
6eff130
adds ids back to generating_signals
ecezalp Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions x-pack/test/detection_engine_api_integration/security_and_spaces/tests/generating_signals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,7 +1265,7 @@ export default ({ getService }: FtrProviderContext) => {
parents: [
{
rule: signalNoRule.parents[0].rule, // rule id is always changing so skip testing it
id: 'b63bcc90b9393f94899991397a3c2df2f3f5c6ebf56440434500f1e1419df7c9',
id: signalNoRule.parents[0].id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't exactly sure why this started braking after pulling in master - noticing the comment a line above, I used the same strategy, please confirm if this is an appropriate fix

Copy link
Contributor

@madirey madirey Jun 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ecezalp Did the ID change because the _id calculation in wrap_hits_factory changed to include the version? I suspect that's the case. If so, we probably want to hard-code the new calculated id here, as it should be stable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhh that makes sense. I updated the ids. locally I got a 409 error which I thought was strange considering that I was just updating the comparison object used in the assertion, I pushed the change anyway, hopefully it should work as expected.

type: 'signal',
index: '.siem-signals-default-000001',
depth: 1,
Expand All @@ -1280,7 +1280,7 @@ export default ({ getService }: FtrProviderContext) => {
},
{
rule: signalNoRule.ancestors[1].rule, // rule id is always changing so skip testing it
id: 'b63bcc90b9393f94899991397a3c2df2f3f5c6ebf56440434500f1e1419df7c9',
id: signalNoRule.ancestors[1].id,
type: 'signal',
index: '.siem-signals-default-000001',
depth: 1,
Expand All @@ -1290,7 +1290,7 @@ export default ({ getService }: FtrProviderContext) => {
depth: 2,
parent: {
rule: signalNoRule.parent?.rule, // parent.rule is always changing so skip testing it
id: 'b63bcc90b9393f94899991397a3c2df2f3f5c6ebf56440434500f1e1419df7c9',
id: signalNoRule.parent?.id,
type: 'signal',
index: '.siem-signals-default-000001',
depth: 1,
Expand Down