[Canvas] Fixes messed up form layout on custom interval form #101967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
poffdeluxe
approved these changes
Jun 17, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 19, 2021
…#101967) * Fixes messed up form layout on custom interval form * update storyshots * Fix snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
This was referenced Jul 19, 2021
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Jul 19, 2021
…#101967) * Fixes messed up form layout on custom interval form * update storyshots * Fix snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Jul 19, 2021
…#101967) * Fixes messed up form layout on custom interval form * update storyshots * Fix snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
crob611
pushed a commit
that referenced
this pull request
Jul 19, 2021
#106088) * Fixes messed up form layout on custom interval form * update storyshots * Fix snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 19, 2021
#106087) * Fixes messed up form layout on custom interval form * update storyshots * Fix snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Corey Robertson <corey.robertson@elastic.co>
crob611
pushed a commit
that referenced
this pull request
Jul 19, 2021
#106089) * Fixes messed up form layout on custom interval form * update storyshots * Fix snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a change to EUI Button that introduces a
minWidthprop. We were usingstyle={}to set the minWidth and it was getting stomped by an undefinedminWidthprop. This fixes that, and fixes the layout.Fixes #100598
Fixes #98198