Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[load testing] adjust ES heap size #101906

Merged

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Jun 10, 2021

Summary

In order to avoid ES search queue limit issue and be able to focus on Kibana performance, we are increasing ES heap size so ElasticSearch feels more comfortable :)

Tested here https://kibana-ci.elastic.co/view/Kibana/job/elastic+kibana+load-testing/531

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dmlemeshko
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Jun 24, 2021
@dmlemeshko dmlemeshko marked this pull request as ready for review June 24, 2021 10:25
@dmlemeshko dmlemeshko requested a review from a team June 24, 2021 10:28
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko merged commit 7a3d61f into elastic:master Jun 24, 2021
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 8, 2021
* [load testing] increase es heap to 2g

* update default simulation

* [heap size] 4g

* [heap size] 6g

* [load testing] es heap size 8g

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 8, 2021
* [load testing] increase es heap to 2g

* update default simulation

* [heap size] 4g

* [heap size] 6g

* [load testing] es heap size 8g

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 8, 2021
* [load testing] increase es heap to 2g

* update default simulation

* [heap size] 4g

* [heap size] 6g

* [load testing] es heap size 8g

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dmlemeshko dmlemeshko added v7.13.4 v7.14.1 v7.15.0 and removed backport:skip This commit does not require backporting labels Jul 8, 2021
dmlemeshko added a commit that referenced this pull request Jul 8, 2021
* [load testing] increase es heap to 2g

* update default simulation

* [heap size] 4g

* [heap size] 6g

* [load testing] es heap size 8g

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko added a commit that referenced this pull request Jul 8, 2021
* [load testing] increase es heap to 2g

* update default simulation

* [heap size] 4g

* [heap size] 6g

* [load testing] es heap size 8g

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko added a commit that referenced this pull request Jul 8, 2021
* [load testing] increase es heap to 2g

* update default simulation

* [heap size] 4g

* [heap size] 6g

* [load testing] es heap size 8g

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dmlemeshko dmlemeshko deleted the load-testing/adjust-es-heap-size branch January 31, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.13.4 v7.14.1 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants