Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Adds a unit test to compare the by value and by ref migrations #101247

Merged
merged 3 commits into from
Jun 4, 2021
Merged

[Visualize] Adds a unit test to compare the by value and by ref migrations #101247

merged 3 commits into from
Jun 4, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jun 3, 2021 •
edited
Loading

Summary

Adds a unit test to visualize migrations to ensure that by value and by ref migrations are the same.

Checklist

@stratoula stratoula changed the title [Visualize] Add unti test to compare the by value and by ref migrations [Visualize] Adds a unti test to compare the by value and by ref migrations Jun 3, 2021
@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 labels Jun 3, 2021
@stratoula stratoula marked this pull request as ready for review June 3, 2021 11:11
@stratoula stratoula requested a review from a team June 3, 2021 11:11
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jun 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula changed the title [Visualize] Adds a unti test to compare the by value and by ref migrations [Visualize] Adds a unit test to compare the by value and by ref migrations Jun 3, 2021
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great addition, I'm going to add that for Lens as well

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 6927d6c into elastic:master Jun 4, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Jun 4, 2021
@stratoula @kibanamachine
[Visualize] Adds a unit test to compare the by value and by ref migra…
890da63 
…tions (elastic#101247)

* [Visualize] Add unti test to compare the by value and by ref migrations

* Fix file name

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@stratoula stratoula mentioned this pull request Jun 4, 2021
Merged
stratoula added a commit that referenced this pull request Jun 4, 2021
@stratoula @kibanamachine
[Visualize] Adds a unit test to compare the by value and by ref migra…
07706a3 
…tions (#101247) (#101359)

* [Visualize] Add unti test to compare the by value and by ref migrations

* Fix file name

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stratoula @elasticmachine @kibanamachine @flash1293