Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker] Set server.shutdownTimeout to match default docker stop timeout #100494

Merged
merged 2 commits into from
May 26, 2021
Merged

[docker] Set server.shutdownTimeout to match default docker stop timeout #100494

merged 2 commits into from
May 26, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented May 24, 2021

The default setting for server.shutdownTimeout is 30s. Docker's
default stop behavior is to send a SIGKILL after 10s. This sets the
graceful shutdown behavior to be inline with Docker defaults.

Related to #97223. Closes #97658

@jbudz
[docker] Set server.shutdownTimeout to match default docker stop timeout
9cd9bd7 
The default setting for `server.shutdownTimeout` is 30s.  Docker's
default stop behavior is to send a SIGKILL after 10s.  This sets the
graceful shutdown behavior to be inline with Docker defaults.

Related to elastic#97223.  Closes elastic#97658
@jbudz jbudz added review Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels May 24, 2021
@jbudz jbudz requested a review from afharo May 24, 2021 19:52
@jbudz jbudz requested a review from a team as a code owner May 24, 2021 19:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz
Copy link
Member Author

jbudz commented May 24, 2021

@afharo do you think it would be prudent to set this below 10s? My understanding is this is closer to http stop than process exit, right?

afharo
afharo approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for doing this @jbudz

@afharo
Copy link
Member

afharo commented May 26, 2021

@afharo do you think it would be prudent to set this below 10s? My understanding is this is closer to http stop than process exit, right?

That's a very good point! Yes, that setting only affects the timeout for the graceful shutdown of the HTTP server. Other dependencies like the ES client might require some time to be stopped afterwards.

@jbudz jbudz enabled auto-merge (squash) May 26, 2021 17:59
@jbudz jbudz added auto-backport Deprecated - use backport:version if exact versions are needed and removed review labels May 26, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 507da3e into elastic:master May 26, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 100494

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 28, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 100494 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 100494 or prevent reminders by adding the backport:skip label.

jbudz added a commit that referenced this pull request Jun 1, 2021
@jbudz
[docker] Set server.shutdownTimeout to match default docker stop time…
ff6a5a8 
…out (#100494)
@jbudz
Copy link
Member Author

jbudz commented Jun 1, 2021

7.x: ff6a5a8

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 1, 2021
@jbudz jbudz mentioned this pull request Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backported release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt Graceful shutdown timeouts depending on the service
5 participants
@jbudz @elasticmachine @afharo @kibanamachine @spalger