Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwriting imported saved objects shows the wrong title #9680

Closed
w33ble opened this issue Dec 29, 2016 · 4 comments
Closed

Overwriting imported saved objects shows the wrong title #9680

w33ble opened this issue Dec 29, 2016 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects good first issue low hanging fruit stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@w33ble
Copy link
Contributor

w33ble commented Dec 29, 2016

Kibana version: Any

Steps to reproduce:

  1. Export a saved object, like a visualization
  2. Edit the saved object, changing its title
  3. Import the JSON you just exported

Expected:

  • Prompted about overwriting saved object ✅
  • Message contains the new name of the saved objects ❌

The message about overwriting the saved object uses the title from the imported JSON, not the current title of the saved object. If you're importing multiple objects, this could get very hard to keep track of.

Discovered while testing #9659

@w33ble w33ble added :Management bug Fixes for quality problems that affect the customer experience labels Dec 29, 2016
@chrisronline
Copy link
Contributor

I think this is fixed? This is the correct behavior, right?

9680

@w33ble
Copy link
Contributor Author

w33ble commented Nov 2, 2017

Nah, it's still showing the new name. That is, the name that's coming from the JSON file, not the name of the existing saved object. I think it's likely users won't know what's in the JSON file, but they see what's there in the interface. So telling them "Usernames2 is about to be overridden" doesn't help, because that's not what is happening. It's confusing because in the interface, there is no "Usernames2" record, "Usernames" is the record that's about the be overridden.

@chrisronline
Copy link
Contributor

Ah, gotcha. Thanks for clarifying!

@timroes timroes added good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed :Management DO NOT USE labels Nov 27, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@timroes timroes removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 30, 2018
friol added a commit to friol/kibana that referenced this issue Aug 27, 2019
friol added a commit to friol/kibana that referenced this issue Aug 28, 2019
friol added a commit to friol/kibana that referenced this issue Aug 29, 2019
@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects good first issue low hanging fruit stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

5 participants