[Lens] Do not submit invalid query in filtered metric #95611
Assignees
Labels
enhancement
New value added to drive a business result
Feature:Lens
good first issue
low hanging fruit
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Comments
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this issue
Aug 3, 2021
alexwizp
added a commit
that referenced
this issue
Aug 11, 2021
* [Lens] Do not submit invalid query in filtered metric Closes: #95611 * fix CI * fix PR comments * fix PR comments * fix PR comment * move closePopover to useCallback * add filter validation to utils/isColumnInvalid Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp
added a commit
to alexwizp/kibana
that referenced
this issue
Aug 11, 2021
…7542) * [Lens] Do not submit invalid query in filtered metric Closes: elastic#95611 * fix CI * fix PR comments * fix PR comments * fix PR comment * move closePopover to useCallback * add filter validation to utils/isColumnInvalid Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp
added a commit
that referenced
this issue
Aug 11, 2021
…108144) * [Lens] Do not submit invalid query in filtered metric Closes: #95611 * fix CI * fix PR comments * fix PR comments * fix PR comment * move closePopover to useCallback * add filter validation to utils/isColumnInvalid Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the query of a filtered metric is invalid, it's still attempting to render the chart which is causing a runtime error:
This should be improved. In case of the filters function an invalid query is implicitly turned into a
*query matching all documents - we could do the same thing here, but maybe we should do something more sensible in both cases like not submitting the query as long as the input is open and on close failing the validation and highlighting the problematic dimension.The text was updated successfully, but these errors were encountered: