-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline Plugin install using absolute file path on Windows should support three protocol slashes #7133
Comments
I noticed with the latest Kibana 4.6.1 that kibana no longer accepts the two slash URL format and now requires the three slashes. Was this actually fixed and part of 4.5.1? I also didn't notice it in the release notes either - https://www.elastic.co/guide/en/kibana/current/releasenotes.html Can someone verify whether this was supposed to be included and this issue closed/updated? |
Changed from Enhancement to Bug since our docs show the standard 3 slash install and Linux works with the 3 slashes. Windows users will have a hard time figuring out how to do it. https://www.elastic.co/guide/en/x-pack/current/installing-xpack.html |
I just want to make sure this doesn't change into docs change for the interim and then this gets closed and we miss actually updating Kibana to be consistent with itself and across the stack. If that makes sense? |
This is still the case in 5.2.0, for the record, so it's not a 4.x thing only. |
This issue still exists. If you try installing a local plugin with 3 slashes it fails, but with 2 slashes it is giving a warning but the installation is successful. Windows 10 It seems |
Hi @jbudz , find below the command and it's output.
You may see the only difference between the commands is the number of slashes. Nothing else was changed to make the install work. |
This works for me on Windows on the latest 6.0.0-beta1 build and on 5.5 and 5.6
@nikhil-ahir-dox Can you try it with the FYI, I use |
The windows regex is matching on |
Yes @jbudz, it only works with three slashes in my case. But I am using using an older version 5.4.0, and it might still have the issue. Will update the version and see how it behaves. Thanks for your replies :) |
Hello @nikhil-ahir-dox, have you this error in the past ? |
In mine case it installed well however i could not able to find on kibana UI after restarting the Kibana server. Please suggest how to check this visualization [root@tv bin]# ./kibana-plugin install file:///tmp/build/status_light_visualization-7.3.2.zip |
Closing, this was resolved in 7.0 |
## PR change summary `v87.2.0`⏩`v88.1.0`⚠️ The biggest thing to QA in this PR is several **breaking changes** to `EuiDescriptionList`. ### Description list `columnWidths` prop This PR introduces a new `columnWidths` prop and removes several Kibana instances of custom CSS overrides to title/description column widths. The primary motivation behind this is not just to reduce custom CSS, but also because v88.0.0 introduced an underlying CSS change of `column` description lists to using [`display: grid` CSS](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_grid_layout). The new prop allows us to support existing description list custom widths while not requiring Kibana developers to understand or write grid CSS (except for 1 or two scenarios around `max-width`).⚠️ **No user-facing UI around column widths should have regressed as a result of these changes. If they have, please let us know in this PR.** ### Description list gutter size changes The prop `gutterSize` has been renamed to `rowGutterSize` and the default size is now `s` instead of `m`. The change to `s` from `m` means there is an **expected** smaller gap between list items (see below screenshots): **Current `EuiDescriptionList` with default `rowGutterSize="s"`** <img width="753" alt="" src="https://github.com/elastic/kibana/assets/934879/c17aef28-ed3b-40c4-84c3-396e788b13bb"> **Prior `EuiDescriptionList` with default `gutterSize="m"`** <img width="721" alt="" src="https://github.com/elastic/kibana/assets/934879/84d5f5a2-8fa6-4f99-9dc0-73fd143aa1e1"> If Kibana teams prefer to keep the previous `m` gutter for their instances of `EuiDescriptionList`, you have a couple of options: 1. Let EUI team know in the PR and we can set usage back to what it was before 2. Set `rowGutterSize="m"` yourselves manually --- ## [`88.1.0`](https://github.com/elastic/eui/tree/v88.1.0) - Added `font.defaultUnits` theme token. EUI component font sizes default to `rem` units - this token allows consumers to configure this to `px` or `em` ([#7133](elastic/eui#7133)) - Updated `EuiDescriptionList` with new `columnWidths` prop ([#7146](elastic/eui#7146)) **Bug fixes** - Fixed `EuiDataGrid`'s keyboard shortcuts popover display ([#7146](elastic/eui#7146)) **CSS-in-JS conversions** - Renamed `useEuiFontSize()`'s `measurement` option to `unit` for clarity ([#7133](elastic/eui#7133)) ## [`88.0.0`](https://github.com/elastic/eui/tree/v88.0.0) - Updated `EuiDescriptionList` with a new `columnGutterSize` prop ([#7062](elastic/eui#7062)) **Deprecations** - Deprecated `EuiSuggest`. We recommend using `EuiSelectable` or `EuiComboBox` instead ([#7122](elastic/eui#7122)) - Deprecated `EuiControlBar`. We recommend using `EuiBottomBar` instead ([#7122](elastic/eui#7122)) - Deprecated `EuiColorStops`. We recommend copying the component to your application if necessary ([#7122](elastic/eui#7122)) - Deprecated `EuiNotificationEvent`. We recommend copying the component to your application if necessary ([#7122](elastic/eui#7122)) **Breaking changes** - Renamed `EuiDescriptionList`'s `gutterSize` prop to `rowGutterSize` ([#7062](elastic/eui#7062)) - `EuiDescriptionList`'s `rowGutterSize` prop now defaults to a size of `s` (was previously `m`) ([#7062](elastic/eui#7062)) **Accessibility** - Fixed the dark mode colors of inline `EuiDescriptionListTitle`s to meet WCAG color contrast requirements ([#7062](elastic/eui#7062)) **CSS-in-JS conversions** - Converted `EuiKeyPadMenuItem` to Emotion; Removed `$euiKeyPadMenuSize` and `$euiKeyPadMenuMarginSize` ([#7118](elastic/eui#7118)) --------- Co-authored-by: Cee Chen <constance.chen@elastic.co> Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
Kibana version: 4.5.0
OS version: Windows 7 and Windows 10
Description of the problem including expected versus actual behavior:
The plugin install using a URL with absolute file path on Windows requires use of two slashes in the protocol
file://C:\
as opposed to threefile:///C:\
.For example the following does not work but should based upon how Elasticsearch behaves and based upon the spec for Windows absolute URLS - https://blogs.msdn.microsoft.com/ie/2006/12/06/file-uris-in-windows/
bin\kibana.bat plugin --install marvel --url file:///C:\elastic\marvel-2.3.2.tar.gz
However the following does work (2 slashes):
bin\kibana.bat plugin --install marvel --url file://C:\elastic\marvel-2.3.2.tar.gz
Notice discussion on this from Elasticsearch end as well - elastic/elasticsearch#18141
The text was updated successfully, but these errors were encountered: