Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Plugin install using absolute file path on Windows should support three protocol slashes #7133

Closed
djschny opened this issue May 4, 2016 · 12 comments · Fixed by #10083
Labels
bug Fixes for quality problems that affect the customer experience Feature:Plugins Team:Operations Team label for Operations Team

Comments

@djschny
Copy link
Contributor

djschny commented May 4, 2016

Kibana version: 4.5.0

OS version: Windows 7 and Windows 10

Description of the problem including expected versus actual behavior:
The plugin install using a URL with absolute file path on Windows requires use of two slashes in the protocol file://C:\ as opposed to three file:///C:\.

For example the following does not work but should based upon how Elasticsearch behaves and based upon the spec for Windows absolute URLS - https://blogs.msdn.microsoft.com/ie/2006/12/06/file-uris-in-windows/

bin\kibana.bat plugin --install marvel --url file:///C:\elastic\marvel-2.3.2.tar.gz

However the following does work (2 slashes):
bin\kibana.bat plugin --install marvel --url file://C:\elastic\marvel-2.3.2.tar.gz

Notice discussion on this from Elasticsearch end as well - elastic/elasticsearch#18141

@epixa epixa changed the title plugin install using absolute file path on Windows requires three protocol slashes Plugin install using absolute file path on Windows should support three protocol slashes Jun 15, 2016
@djschny
Copy link
Contributor Author

djschny commented Oct 3, 2016

I noticed with the latest Kibana 4.6.1 that kibana no longer accepts the two slash URL format and now requires the three slashes. Was this actually fixed and part of 4.5.1?

I also didn't notice it in the release notes either - https://www.elastic.co/guide/en/kibana/current/releasenotes.html

Can someone verify whether this was supposed to be included and this issue closed/updated?

@jbudz jbudz added the Team:Operations Team label for Operations Team label Nov 1, 2016
@LeeDr LeeDr changed the title Plugin install using absolute file path on Windows should support three protocol slashes Offline Plugin install using absolute file path on Windows should support three protocol slashes Nov 2, 2016
@LeeDr LeeDr added Feature:Plugins bug Fixes for quality problems that affect the customer experience Team:Docs and removed release_note:enhancement labels Nov 2, 2016
@LeeDr
Copy link

LeeDr commented Nov 2, 2016

Changed from Enhancement to Bug since our docs show the standard 3 slash install and Linux works with the 3 slashes. Windows users will have a hard time figuring out how to do it.

https://www.elastic.co/guide/en/x-pack/current/installing-xpack.html

@djschny
Copy link
Contributor Author

djschny commented Nov 2, 2016

Changed from Enhancement to Bug since our docs show the standard 3 slash install and Linux works with the 3 slashes.

I just want to make sure this doesn't change into docs change for the interim and then this gets closed and we miss actually updating Kibana to be consistent with itself and across the stack. If that makes sense?

@epixa
Copy link
Contributor

epixa commented Jan 26, 2017

This is still the case in 5.2.0, for the record, so it's not a 4.x thing only.

@nikhil-ahir-dox
Copy link

This issue still exists. If you try installing a local plugin with 3 slashes it fails, but with 2 slashes it is giving a warning but the installation is successful.

Windows 10
Kibana 5.4.0
node 6.10.2

It seems statSync is failing with 3 slashes.

@jbudz jbudz reopened this Aug 7, 2017
@nikhil-ahir-dox
Copy link

nikhil-ahir-dox commented Aug 7, 2017

Hi @jbudz , find below the command and it's output.

With 3 slashes (Still does not work) :-

$ bin/kibana-plugin install file:///c/projects/newKibana/hello/build/hello-1.0.0.zip
Attempting to transfer from file:///c/projects/newKibana/hello/build/hello-1.0.0.zip
Error: ENOTFOUND
Attempting to transfer from https://artifacts.elastic.co/downloads/kibana-plugins/file:///c/projects/newKibana/hello/build/hello-1.0.0.zip/file:///c/projects/newKibana/hello/build/hello-1.0.0.zip-5.4.0.zip
Plugin installation was unsuccessful due to error "No valid url specified."

With 2 slashes (though it gives deprecation warning it works) :-

$ bin/kibana-plugin install file://c/projects/newKibana/hello/build/hello-1.0.0.zip
Attempting to transfer from file://c/projects/newKibana/hello/build/hello-1.0.0.zip
Install paths with file:// are deprecated, use file:/// instead
Transferring 7243 bytes....................
Transfer complete
Retrieving metadata from plugin archive
Extracting plugin archive
Extraction complete
Optimizing and caching browser bundles...
Plugin installation complete

You may see the only difference between the commands is the number of slashes. Nothing else was changed to make the install work.

@LeeDr
Copy link

LeeDr commented Aug 7, 2017

This works for me on Windows on the latest 6.0.0-beta1 build and on 5.5 and 5.6
(note that I'm calling the batch file from a git bash shell on Windows);

/c/windowsInstalls/6.0.0-beta1/kibana/bin/kibana-plugin.bat install file:///C:/vagrant/qa/x-pack-6.0.0-beta1.zip

@nikhil-ahir-dox Can you try it with the : for the drive letter?

FYI, I use cygpath -m to get that "mixed" format of having the Windows : along with forward slashes.

@jbudz
Copy link
Member

jbudz commented Aug 7, 2017

The windows regex is matching on drive:/ so it isn't going to match in this case. Is C your drive @nikhil-ahir-dox? Does `file:///c:/projects/newKibana/hello/build/hello-1.0.0.zip work?

@nikhil-ahir-dox
Copy link

Yes @jbudz, it only works with three slashes in my case. But I am using using an older version 5.4.0, and it might still have the issue. Will update the version and see how it behaves. Thanks for your replies :)

@khelmrab
Copy link

Hello @nikhil-ahir-dox,
Kibana 5.4.0 i build run successful for you ?
i have this errors
WARNING in ./build/kibana/src/ui/public/styles/truncate.less
Module build failed: ModuleBuildError: Module build failed: Error: EINVAL: invalid argument, uv_interface_addresses

have you this error in the past ?
thank's

@mohitmehral
Copy link

mohitmehral commented Jan 15, 2020

In mine case it installed well however i could not able to find on kibana UI after restarting the Kibana server. Please suggest how to check this visualization

[root@tv bin]# ./kibana-plugin install file:///tmp/build/status_light_visualization-7.3.2.zip
Kibana should not be run as root. Use --allow-root to continue.
[root@tv bin]# ./kibana-plugin --allow-root install file:///tmp/build/status_light_visualization-7.3.2.zip
Found previous install attempt. Deleting...
Attempting to transfer from file:///tmp/build/status_light_visualization-7.3.2.zip
Transferring 9452 bytes....................
Transfer complete
Retrieving metadata from plugin archive
Extracting plugin archive
Extraction complete

@tylersmalley
Copy link
Contributor

Closing, this was resolved in 7.0

jbudz pushed a commit that referenced this issue Sep 5, 2023
## PR change summary

`v87.2.0`⏩`v88.1.0`

⚠️ The biggest thing to QA in this PR is several **breaking changes** to
`EuiDescriptionList`.

### Description list `columnWidths` prop

This PR introduces a new `columnWidths` prop and removes several Kibana
instances of custom CSS overrides to title/description column widths.

The primary motivation behind this is not just to reduce custom CSS, but
also because v88.0.0 introduced an underlying CSS change of `column`
description lists to using [`display: grid`
CSS](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_grid_layout).
The new prop allows us to support existing description list custom
widths while not requiring Kibana developers to understand or write grid
CSS (except for 1 or two scenarios around `max-width`).

⚠️ **No user-facing UI around column widths should have regressed as a
result of these changes. If they have, please let us know in this PR.**

### Description list gutter size changes

The prop `gutterSize` has been renamed to `rowGutterSize` and the
default size is now `s` instead of `m`.

The change to `s` from `m` means there is an **expected** smaller gap
between list items (see below screenshots):

**Current `EuiDescriptionList` with default `rowGutterSize="s"`**
<img width="753" alt=""
src="https://github.com/elastic/kibana/assets/934879/c17aef28-ed3b-40c4-84c3-396e788b13bb">

**Prior `EuiDescriptionList` with default `gutterSize="m"`**
<img width="721" alt=""
src="https://github.com/elastic/kibana/assets/934879/84d5f5a2-8fa6-4f99-9dc0-73fd143aa1e1">

If Kibana teams prefer to keep the previous `m` gutter for their
instances of `EuiDescriptionList`, you have a couple of options:

1. Let EUI team know in the PR and we can set usage back to what it was
before
2. Set `rowGutterSize="m"` yourselves manually

---

## [`88.1.0`](https://github.com/elastic/eui/tree/v88.1.0)

- Added `font.defaultUnits` theme token. EUI component font sizes
default to `rem` units - this token allows consumers to configure this
to `px` or `em` ([#7133](elastic/eui#7133))
- Updated `EuiDescriptionList` with new `columnWidths` prop
([#7146](elastic/eui#7146))

**Bug fixes**

- Fixed `EuiDataGrid`'s keyboard shortcuts popover display
([#7146](elastic/eui#7146))

**CSS-in-JS conversions**

- Renamed `useEuiFontSize()`'s `measurement` option to `unit` for
clarity ([#7133](elastic/eui#7133))

## [`88.0.0`](https://github.com/elastic/eui/tree/v88.0.0)

- Updated `EuiDescriptionList` with a new `columnGutterSize` prop
([#7062](elastic/eui#7062))

**Deprecations**

- Deprecated `EuiSuggest`. We recommend using `EuiSelectable` or
`EuiComboBox` instead
([#7122](elastic/eui#7122))
- Deprecated `EuiControlBar`. We recommend using `EuiBottomBar` instead
([#7122](elastic/eui#7122))
- Deprecated `EuiColorStops`. We recommend copying the component to your
application if necessary
([#7122](elastic/eui#7122))
- Deprecated `EuiNotificationEvent`. We recommend copying the component
to your application if necessary
([#7122](elastic/eui#7122))

**Breaking changes**

- Renamed `EuiDescriptionList`'s `gutterSize` prop to `rowGutterSize`
([#7062](elastic/eui#7062))
- `EuiDescriptionList`'s `rowGutterSize` prop now defaults to a size of
`s` (was previously `m`)
([#7062](elastic/eui#7062))

**Accessibility**

- Fixed the dark mode colors of inline `EuiDescriptionListTitle`s to
meet WCAG color contrast requirements
([#7062](elastic/eui#7062))

**CSS-in-JS conversions**

- Converted `EuiKeyPadMenuItem` to Emotion; Removed `$euiKeyPadMenuSize`
and `$euiKeyPadMenuMarginSize`
([#7118](elastic/eui#7118))

---------

Co-authored-by: Cee Chen <constance.chen@elastic.co>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Plugins Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants