Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add beta badges to Service maps feature #60265

Closed
3 tasks done
formgeist opened this issue Mar 16, 2020 · 3 comments · Fixed by #60482
Closed
3 tasks done

[APM] Add beta badges to Service maps feature #60265

formgeist opened this issue Mar 16, 2020 · 3 comments · Fixed by #60482
Assignees
@ogupte
Labels
apm:service-maps Service Map feature in APM enhancement New value added to drive a business result Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.7.0

Comments

@formgeist
Copy link
Contributor

formgeist commented Mar 16, 2020 •
edited by ogupte
Loading

Summary

We want to add a beta badge to the Service maps feature in order to realistically meet users' expectations and if they encounter bugs they're welcome to report them to us before it goes generally available.

Solution

  • Add beta badge to the map controls area of the map

Global map

  • Exchange the EuiEmptyPrompt with a new EuiPanel with the betabadge enabled.
    Service maps - Roadblock platinum license

  • Both badges will have the following copy;
    Title: Beta
    Description: This feature is currently in beta. If you encounter any bugs or have feedback, please open an issue or visit our discussion forum.
@formgeist formgeist added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. enhancement New value added to drive a business result v7.7.0 apm:service-maps Service Map feature in APM labels Mar 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes
Copy link
Contributor

I've refactored the Service map license prompt, I extracted it to a shared component. 1cfd8bed

@formgeist
Copy link
Contributor Author

@cauemarcondes Awesome, wanted to check whether you were using EuiEmptyPrompt in this component, but seeing as it's just a regular EuiPanel you should be able to simply specify betaBadgeLabel={Beta} on it to get it to look like the design above.

@ogupte ogupte self-assigned this Mar 18, 2020
ogupte added a commit to ogupte/kibana that referenced this issue Mar 18, 2020
@ogupte
Closes elastic#60265. Adds Beta badge to service map
fbf1cfb
@ogupte ogupte mentioned this issue Mar 18, 2020
Merged
@ogupte ogupte added apm:service-maps Service Map feature in APM v7.7.0 enhancement New value added to drive a business result Team:APM - DEPRECATED Use Team:obs-ux-infra_services. and removed apm:service-maps Service Map feature in APM Team:APM - DEPRECATED Use Team:obs-ux-infra_services. enhancement New value added to drive a business result v7.7.0 labels Mar 18, 2020
@ogupte ogupte self-assigned this Mar 18, 2020
ogupte added a commit that referenced this issue Mar 18, 2020
@ogupte
Closes #60265. Adds Beta badge to service map (#60482)
6abb9d7
ogupte added a commit to ogupte/kibana that referenced this issue Mar 18, 2020
@ogupte
Closes elastic#60265. Adds Beta badge to service map (elastic#60482)
5fd6bd9
@ogupte ogupte mentioned this issue Mar 18, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this issue Mar 18, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
02b6be3 
* master:
  [NP] Cutover ensureDefaultIndexPattern to kibana_utils (elastic#59895)
  Closes elastic#60265. Adds Beta badge to service map (elastic#60482)
  [Visualize] Duplicated query filters in es request (elastic#60106)
  [ML] Disable functional transform tests
  Fixes to service map single node banner (elastic#60072)
  [Uptime] replace fetch with kibana http (elastic#59881)
  Upgrade @types/node to match Node.js runtime (elastic#60368)
jloleysens added a commit that referenced this issue Mar 18, 2020
@jloleysens
Merge branch 'app/painless' of github.com:elastic/kibana into app/pai…
8733480 
…nless

* 'app/painless' of github.com:elastic/kibana: (64 commits)
  Fix filter scope in bool query (#60488)
  change index pattern id to be the same as index pattern title (#60436)
  [Endpoint] resolver v1 events (#59233)
  Branding fixes for dashboard, loader and space selector (#60073)
  skip flaky suite (#60535)
  [SIEM][Detection Engine] Fixes bug with timeline templates not working
  Fixed errors which are happening if switch between alert types (#60453)
  [EPM] Add mapping field types to index template generation v2 (#60266)
  [NP] Cutover ensureDefaultIndexPattern to kibana_utils (#59895)
  Closes #60265. Adds Beta badge to service map (#60482)
  [Visualize] Duplicated query filters in es request (#60106)
  [ML] Disable functional transform tests
  Fixes to service map single node banner (#60072)
  [Uptime] replace fetch with kibana http (#59881)
  Upgrade @types/node to match Node.js runtime (#60368)
  [License Management] NP migration (#60250)
  Fix create alert button from not showing in alerts list (#60444)
  [SIEM][Case] Update connector through flyout (#60307)
  add data-test-subj where possible on SO management table (#60226)
  Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (#60406)
  ...
dgieselaar pushed a commit that referenced this issue Mar 19, 2020
@ogupte
[7.x] Closes #60265. Adds Beta badge to service map (#60482) (#60521)
53531ef
jloleysens added a commit to jloleysens/kibana that referenced this issue Mar 19, 2020
@jloleysens
Merge remote-tracking branch 'upstream/app/painless' into minor-refactor
3f00238 
* upstream/app/painless: (66 commits)
  Another i18n issue
  Fix i18n
  Fix filter scope in bool query (elastic#60488)
  change index pattern id to be the same as index pattern title (elastic#60436)
  [Endpoint] resolver v1 events (elastic#59233)
  Branding fixes for dashboard, loader and space selector (elastic#60073)
  skip flaky suite (elastic#60535)
  [SIEM][Detection Engine] Fixes bug with timeline templates not working
  Fixed errors which are happening if switch between alert types (elastic#60453)
  [EPM] Add mapping field types to index template generation v2 (elastic#60266)
  [NP] Cutover ensureDefaultIndexPattern to kibana_utils (elastic#59895)
  Closes elastic#60265. Adds Beta badge to service map (elastic#60482)
  [Visualize] Duplicated query filters in es request (elastic#60106)
  [ML] Disable functional transform tests
  Fixes to service map single node banner (elastic#60072)
  [Uptime] replace fetch with kibana http (elastic#59881)
  Upgrade @types/node to match Node.js runtime (elastic#60368)
  [License Management] NP migration (elastic#60250)
  Fix create alert button from not showing in alerts list (elastic#60444)
  [SIEM][Case] Update connector through flyout (elastic#60307)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
apm:service-maps Service Map feature in APM enhancement New value added to drive a business result Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Service map beta badge ogupte/kibana
5 participants
@sorenlouv @ogupte @formgeist @elasticmachine @cauemarcondes