Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Remove [Beta] label from breakdown graphs #47161

Closed
sorenlouv opened this issue Oct 2, 2019 · 2 comments · Fixed by #47163
Closed

[APM] Remove [Beta] label from breakdown graphs #47161

sorenlouv opened this issue Oct 2, 2019 · 2 comments · Fixed by #47163
Assignees
@dgieselaar
Labels
enhancement New value added to drive a business result good first issue low hanging fruit Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.5.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Oct 2, 2019 •
edited
Loading

The breakdown graphs are GA in 7.5 so the beta label should be removed

image

kibana/x-pack/legacy/plugins/apm/public/components/shared/TransactionBreakdown/TransactionBreakdownHeader.tsx

Lines 34 to 47 in bc840e6

<EuiFlexItem grow={false}>
<EuiBetaBadge
label={i18n.translate('xpack.apm.ui.betaBadgeLabel', {
defaultMessage: 'Beta'
})}
tooltipContent={i18n.translate(
'xpack.apm.ui.betaBadgeTooltipTitle',
{
defaultMessage:
'This feature is still in development. If you have feedback, please reach out in our Discuss forum.'
}
)}
/>
</EuiFlexItem>

@sorenlouv sorenlouv added release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Oct 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar
Copy link
Member

Hmm, I thought I removed it in #46684. I even added a screenshot that showed that it was removed 😅 I wonder what happened...

dgieselaar added a commit to dgieselaar/kibana that referenced this issue Oct 2, 2019
@dgieselaar
[APM] Remove beta badge from transaction breakdown
27181aa 
Closes elastic#47161.
@dgieselaar dgieselaar mentioned this issue Oct 2, 2019
Merged
@sorenlouv sorenlouv added enhancement New value added to drive a business result and removed release_note:skip Skip the PR/issue when compiling release notes labels Oct 3, 2019
dgieselaar added a commit that referenced this issue Oct 3, 2019
@dgieselaar
[APM] Remove beta badge from transaction breakdown (#47163)
d24db49 
Closes #47161.
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Oct 3, 2019
@dgieselaar
[APM] Remove beta badge from transaction breakdown (elastic#47163)
6f7cd98 
Closes elastic#47161.
dgieselaar added a commit that referenced this issue Oct 4, 2019
@dgieselaar
[7.x] [APM] Remove beta badge from transaction breakdown (#471… (#47240)
bccc74c 
Closes #47161.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
enhancement New value added to drive a business result good first issue low hanging fruit Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Remove beta badge from transaction breakdown dgieselaar/kibana
4 participants
@smith @sorenlouv @dgieselaar @elasticmachine