Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Don't show "Clear filters" if no filters are applied #43853

Closed
sorenlouv opened this issue Aug 23, 2019 · 1 comment · Fixed by #43967
Closed

[APM] Don't show "Clear filters" if no filters are applied #43853

sorenlouv opened this issue Aug 23, 2019 · 1 comment · Fixed by #43967
Assignees
@dgieselaar
Labels
enhancement New value added to drive a business result good first issue low hanging fruit Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.4.0

Comments

@sorenlouv
Copy link
Member

Currently a "Clear filters" link is always displayed, and if no filters are applied it has no effect clicking it. This can be a little confusing.

If the "Clear filters" link was only displayed when filters were active, it would also make it more clear whether filters were active or not.
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@sorenlouv sorenlouv added the enhancement New value added to drive a business result label Aug 23, 2019
@dgieselaar dgieselaar self-assigned this Aug 26, 2019
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Aug 26, 2019
@dgieselaar
[APM] Only show "Clear filters" button when values are not empty
abf0e4d 
Closes elastic#43853.
@dgieselaar dgieselaar mentioned this issue Aug 26, 2019
Merged
dgieselaar added a commit that referenced this issue Aug 26, 2019
@dgieselaar
[APM] Only show "Clear filters" button when values are not empty (#43967
df51883 
)

Closes #43853.
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Aug 26, 2019
@dgieselaar
[APM] Only show "Clear filters" button when values are not empty (ela…
bdaf39b 
…stic#43967)

Closes elastic#43853.
dgieselaar added a commit that referenced this issue Aug 26, 2019
@dgieselaar
[APM] Only show "Clear filters" button when values are not empty (#43967
ae2083a 
) (#43992)

Closes #43853.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
enhancement New value added to drive a business result good first issue low hanging fruit Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Only show "Clear filters" button when values are not empty dgieselaar/kibana
3 participants
@sorenlouv @dgieselaar @elasticmachine