Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data #43444

Closed
6 tasks done
streamich opened this issue Aug 16, 2019 · 1 comment · Fixed by #53794
Closed
6 tasks done

Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data #43444

streamich opened this issue Aug 16, 2019 · 1 comment · Fixed by #53794
Assignees
@alexwizp
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:NP Migration

Comments

@streamich
Copy link
Contributor

streamich commented Aug 16, 2019 •
edited by alexwizp
Loading

  • src/legacy/core_plugins/data 👉 src/plugins/data
    • Create .indexPatterns service in src/plugins/data
    • Move contents of src/legacy/core_plugins/data to the new plugin
    • Leave angular IndexPatternProvider for backward compatibility
    • Move Jest mocks to .indexPatterns in src/plugins/data/public/mocks.ts and ensure they are updated
    • Make sure that all index pattern related imports use NP (and delete index_pattern folder from shim) [Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data #53794] @alexwizp

Parent issue: #43438
@streamich streamich added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:NP Migration Team:AppArch labels Aug 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@streamich streamich mentioned this issue Aug 16, 2019
Closed
9 tasks
@lukeelmers lukeelmers changed the title ui/index_patterns 👉 src/plugins/data Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data Aug 26, 2019
@alexwizp alexwizp assigned gospodarsky and unassigned gospodarsky Nov 5, 2019
@gospodarsky gospodarsky mentioned this issue Nov 25, 2019
Merged
7 tasks
@gospodarsky gospodarsky assigned alexwizp and unassigned gospodarsky Dec 20, 2019
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 24, 2019
@alexwizp
Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data
aea2047 
Closes: elastic#43444

Make sure that all index pattern related imports use NP (and delete index_pattern folder from shim)
@alexwizp alexwizp mentioned this issue Dec 24, 2019
Merged
7 tasks
alexwizp added a commit that referenced this issue Jan 3, 2020
@alexwizp @elasticmachine
Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (#…
6942d0b 
…53794)

* Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data

Closes: #43444

Make sure that all index pattern related imports use NP (and delete index_pattern folder from shim)

* fix JEST tests

* fix CI

* fix PR comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 3, 2020
@alexwizp @elasticmachine
Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (e…
7551b12 
…lastic#53794)

* Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data

Closes: elastic#43444

Make sure that all index pattern related imports use NP (and delete index_pattern folder from shim)

* fix JEST tests

* fix CI

* fix PR comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp added a commit that referenced this issue Jan 3, 2020
@alexwizp @elasticmachine
Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (#…
9f885ed 
…53794) (#53936)

* Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data

Closes: #43444

Make sure that all index pattern related imports use NP (and delete index_pattern folder from shim)

* fix JEST tests

* fix CI

* fix PR comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:NP Migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data alexwizp/kibana
5 participants
@lukeelmers @streamich @elasticmachine @gospodarsky @alexwizp