Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications lifetimes cannot be set to Infinity in Advanced Settings #30109

Closed
nickpeihl opened this issue Feb 5, 2019 · 9 comments · Fixed by #97384
Closed

Notifications lifetimes cannot be set to Infinity in Advanced Settings #30109

nickpeihl opened this issue Feb 5, 2019 · 9 comments · Fixed by #97384
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@nickpeihl
Copy link
Member

Kibana version:
master

Original install method (e.g. download page, yum, from source, etc.):
from source

Describe the bug:
The Notifications section under Advanced Settings recommends setting the notification lifetime to "Infinity" to disable notifications. However, the text box only accepts numeric entries.

Steps to reproduce:

  1. Open the Advanced Settings page in Kibana
  2. Attempt to set any of the Notification Lifetime settings to "Infinity"

Expected behavior:
The docs should specify a number (0?) instead of "Infinity"

Screenshots (if relevant):
screen shot 2019-02-05 at 9 28 51 am

@nreese nreese added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Feb 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@eedugon
Copy link

eedugon commented Feb 11, 2019

Would it be worthy to add somewhere in the docs or the UI the information that the banner notification settings are not related with the toast notifications and that the latest ones cannot be disabled?

@eddieturizo
Copy link

eddieturizo commented Apr 19, 2019

Looks like the code is written to accept Infinity or 0, but the box for the setting in Kibana only takes input type number:

Screen Shot 2019-04-19 at 10 25 34 AM

Tested using 6.6.1

Also verified the same behavior exists in 7.0.0

@ghost
Copy link

ghost commented Jan 30, 2020

Same problem in 7.5.1

@tehmaspc
Copy link

tehmaspc commented Feb 17, 2021

Is the workaround 0 then for now?

UPDATE:
Nope - 0 nor negative integers doesn't seem to work.

@spalger
Copy link
Contributor

spalger commented Feb 17, 2021

Alternate workaround would be to set a large number like 31536000000 which represents 365 days in milliseconds.

@tehmaspc
Copy link

@spalger - thanks - I just tried 90days (in milliseconds) and it seemed to not like such high numbers in that field. I could be mistaken.

However, it now seems to me that the banner is always displayed for that set amount of time whenever someone logs onto Kibana (session based) - which for my use case is perfect and thus the default time to live for the message should be sufficient for me. My team manages a shared cluster and I've been having difficulty getting certain messages across to users on where they should go for support / etc :)

@ducttapecoder-vt
Copy link

ducttapecoder-vt commented Jul 28, 2021

@TinaHeiligers I'm a little lost in the merges here. What is the correct numeric value for 'infinity'? We are still on 7.10 and '0' does not seem to work.

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Jul 28, 2021

@ducttapecoder-vt At the moment, I don't think there is a "correct numeric value" for 'Infinity'. The UI's and underlying implementations are constantly being developed and we'll look into re-defining a definitive number in feature enhancements. That being said, I think it's best to use a sufficiently large number for your use case. Maybe start off with a month?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants