-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] JOIN
command autocomplete improvements
#206939
Labels
enhancement
New value added to drive a business result
Feature:ES|QL
ES|QL related features in Kibana
Team:ESQL
ES|QL related features in Kibana
Comments
Pinging @elastic/kibana-esql (Team:ESQL) |
1 task
vadimkibana
added a commit
that referenced
this issue
Feb 3, 2025
## Summary Partially addresses #206939 This PR introduces the following changes in the `JOIN` command autocomplete. Shows intersection of source index and join index fields, moves those fields to the very top of the list. In the below example the `currency` field appears in both indices, hence, it is at the very top and with a different icon: <img width="786" alt="Screenshot 2025-01-28 at 21 29 52" src="https://github.com/user-attachments/assets/2c1a058f-80a2-4060-a20e-4a0681043dde" /> Adds join index fields to the total list of all fields. In the below example, the `continenet` field is available only in the joined index, but it is added to the total list. <img width="713" alt="Screenshot 2025-01-28 at 21 30 08" src="https://github.com/user-attachments/assets/7cd44ebf-5fe9-4051-a6eb-3feb28801fa5" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
vadimkibana
added a commit
to vadimkibana/kibana
that referenced
this issue
Feb 5, 2025
) ## Summary Partially addresses elastic#206939 This PR introduces the following changes in the `JOIN` command autocomplete. Shows intersection of source index and join index fields, moves those fields to the very top of the list. In the below example the `currency` field appears in both indices, hence, it is at the very top and with a different icon: <img width="786" alt="Screenshot 2025-01-28 at 21 29 52" src="https://github.com/user-attachments/assets/2c1a058f-80a2-4060-a20e-4a0681043dde" /> Adds join index fields to the total list of all fields. In the below example, the `continenet` field is available only in the joined index, but it is added to the total list. <img width="713" alt="Screenshot 2025-01-28 at 21 30 08" src="https://github.com/user-attachments/assets/7cd44ebf-5fe9-4051-a6eb-3feb28801fa5" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 5600f2b)
vadimkibana
added a commit
to vadimkibana/kibana
that referenced
this issue
Feb 5, 2025
) ## Summary Partially addresses elastic#206939 This PR introduces the following changes in the `JOIN` command autocomplete. Shows intersection of source index and join index fields, moves those fields to the very top of the list. In the below example the `currency` field appears in both indices, hence, it is at the very top and with a different icon: <img width="786" alt="Screenshot 2025-01-28 at 21 29 52" src="https://github.com/user-attachments/assets/2c1a058f-80a2-4060-a20e-4a0681043dde" /> Adds join index fields to the total list of all fields. In the below example, the `continenet` field is available only in the joined index, but it is added to the total list. <img width="713" alt="Screenshot 2025-01-28 at 21 30 08" src="https://github.com/user-attachments/assets/7cd44ebf-5fe9-4051-a6eb-3feb28801fa5" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 5600f2b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New value added to drive a business result
Feature:ES|QL
ES|QL related features in Kibana
Team:ESQL
ES|QL related features in Kibana
LOOKUP JOIN
, when suggestingON <condition>
fields, compute lookup index and source index field intersection and show only those fields that are part of both sets.Not yet released by Elasticsearch:
LEFT JOIN
andRIGHT JOIN
support autocompletion, once those two command types are available.... AS ...
alias, support once it is working.The text was updated successfully, but these errors were encountered: